mirror of
https://github.com/servo/servo.git
synced 2025-08-18 11:55:39 +01:00
Auto merge of #29641 - CYBAI:fix-attr-checking, r=jdm
Throw HierarchyRequest error for attr node in pre-insertion Based on Step 4 of https://dom.spec.whatwg.org/#concept-node-ensure-pre-insertion-validity, we should throw `HierarchyRequest` error when the node is not a [DocumentFragment](https://dom.spec.whatwg.org/#documentfragment), [DocumentType](https://dom.spec.whatwg.org/#documenttype), [Element](https://dom.spec.whatwg.org/#element), or [CharacterData](https://dom.spec.whatwg.org/#characterdata) [node](https://dom.spec.whatwg.org/#concept-node). Thus, Attr is not one of them; we should throw an error in this case. (I'm guessing it was a kind of typo in https://github.com/servo/servo/pull/25310 because we need to handle Attr with `unreachable` in line 1946) So, with doing so, we can fix the CRASH in `/dom/attributes-are-nodes.html`. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) - [x] There are tests for these changes
This commit is contained in:
commit
bf29f59adf
3 changed files with 7 additions and 9 deletions
|
@ -1,2 +0,0 @@
|
|||
[attributes-are-nodes.html]
|
||||
expected: CRASH
|
|
@ -1,2 +0,0 @@
|
|||
[attributes-are-nodes.html]
|
||||
expected: CRASH
|
Loading…
Add table
Add a link
Reference in a new issue