Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-04 21:20:23 +01:00
Code Issues Projects Releases Packages Wiki Activity

Implement 'do nothing' methods on Window and Document

Browse source
This commit is contained in:
Corey Farwell 2015-08-26 11:17:03 -04:00
parent 1384ff5e9f
commit bf50145fbd
6 changed files with 35 additions and 39 deletions
Download patch file Download diff file Expand all files Collapse all files

17
components/script/dom/document.rs
View file

@ -1911,12 +1911,27 @@ impl<'a> DocumentMethods for &'a Document {
collection.r().reflector().get_jsobject().get()
}
// https://html.spec.whatwg.org/#document
// https://html.spec.whatwg.org/multipage/#document
fn SupportedPropertyNames(self) -> Vec<DOMString> {
// FIXME: unimplemented (https://github.com/servo/servo/issues/7273)
vec![]
}
// https://html.spec.whatwg.org/multipage/#dom-document-clear
fn Clear(self) {
// This method intentionally does nothing
}
// https://html.spec.whatwg.org/multipage/#dom-document-captureevents
fn CaptureEvents(self) {
// This method intentionally does nothing
}
// https://html.spec.whatwg.org/#dom-document-releaseevents
fn ReleaseEvents(self) {
// This method intentionally does nothing
}
global_event_handlers!();
event_handler!(readystatechange, GetOnreadystatechange, SetOnreadystatechange);
}

6
components/script/dom/webidls/Document.webidl
View file

@ -146,9 +146,9 @@ partial interface Document {
[SameObject]
readonly attribute HTMLCollection applets;
// void clear();
// void captureEvents();
// void releaseEvents();
void clear();
void captureEvents();
void releaseEvents();
// Tracking issue for document.all: https://github.com/servo/servo/issues/7396
// readonly attribute HTMLAllCollection all;

6
components/script/dom/webidls/Window.webidl
View file

@ -93,6 +93,12 @@ partial interface Window {
/*[Replaceable]*/ readonly attribute Performance performance;
};
// https://html.spec.whatwg.org/multipage/#Window-partial
partial interface Window {
void captureEvents();
void releaseEvents();
};
// https://drafts.csswg.org/cssom/#extensions-to-the-window-interface
partial interface Window {
[NewObject]

10
components/script/dom/window.rs
View file

@ -542,6 +542,16 @@ impl<'a> WindowMethods for &'a Window {
doc.r().cancel_animation_frame(ident);
}
// https://html.spec.whatwg.org/multipage/#dom-window-captureevents
fn CaptureEvents(self) {
// This method intentionally does nothing
}
// https://html.spec.whatwg.org/multipage/#dom-window-releaseevents
fn ReleaseEvents(self) {
// This method intentionally does nothing
}
// check-tidy: no specs after this line
fn Debug(self, message: DOMString) {
debug!("{}", message);

18
tests/wpt/metadata/html/dom/interfaces.html.ini
View file

@ -66,15 +66,6 @@
[Document interface: attribute alinkColor]
expected: FAIL
[Document interface: operation clear()]
expected: FAIL
[Document interface: operation captureEvents()]
expected: FAIL
[Document interface: operation releaseEvents()]
expected: FAIL
[Document interface: attribute all]
expected: FAIL
@ -1140,15 +1131,6 @@
[Document interface: document.implementation.createDocument(null, "", null) must inherit property "alinkColor" with the proper type (74)]
expected: FAIL
[Document interface: document.implementation.createDocument(null, "", null) must inherit property "clear" with the proper type (78)]
expected: FAIL
[Document interface: document.implementation.createDocument(null, "", null) must inherit property "captureEvents" with the proper type (79)]
expected: FAIL
[Document interface: document.implementation.createDocument(null, "", null) must inherit property "releaseEvents" with the proper type (80)]
expected: FAIL
[Document interface: document.implementation.createDocument(null, "", null) must inherit property "all" with the proper type (81)]
expected: FAIL

17
tests/wpt/metadata/html/obsolete/requirements-for-implementations/other-elements-attributes-and-apis/nothing.html.ini
View file

@ -1,17 +0,0 @@
[nothing.html]
type: testharness
[document.clear]
expected: FAIL
[document.captureEvents]
expected: FAIL
[document.releaseEvents]
expected: FAIL
[window.captureEvents]
expected: FAIL
[window.releaseEvents]
expected: FAIL