Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 06:00:15 +01:00
Code Issues Projects Releases Packages Wiki Activity

style: Simplify naming and signatures of single-colon pseudo stuff.

Browse source 
Also drop a few FIXMEs while at it, since they look bogus.
This commit is contained in:
Emilio Cobos Álvarez 2017-12-09 16:11:39 +01:00
parent 051a715721
commit bf564e0238
No known key found for this signature in database
GPG key ID: 056B727BB9C1027C
2 changed files with 11 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

6
components/selectors/parser.rs
View file

@ -127,7 +127,7 @@ pub trait Parser<'i> {
/// Whether the name is a pseudo-element that can be specified with
/// the single colon syntax in addition to the double-colon syntax.
fn is_pseudo_element_allows_single_colon(name: &CowRcStr<'i>) -> bool {
fn pseudo_element_allows_single_colon(name: &str) -> bool {
is_css2_pseudo_element(name)
}
@ -1701,7 +1701,7 @@ where
/// Returns whether the name corresponds to a CSS2 pseudo-element that
/// can be specified with the single colon syntax (in addition to the
/// double-colon syntax, which can be used for all pseudo-elements).
pub fn is_css2_pseudo_element<'i>(name: &CowRcStr<'i>) -> bool {
pub fn is_css2_pseudo_element(name: &str) -> bool {
// ** Do not add to this list! **
match_ignore_ascii_case! { name,
"before" | "after" | "first-line" | "first-letter" => true,
@ -1760,7 +1760,7 @@ where
)),
};
let is_pseudo_element = !is_single_colon ||
P::is_pseudo_element_allows_single_colon(&name);
P::pseudo_element_allows_single_colon(&name);
if is_pseudo_element {
let pseudo_element = if is_functional {
input.parse_nested_block(|input| {