From 525fdd431d9b1697872a01394246794bd0a3c395 Mon Sep 17 00:00:00 2001 From: Jack Moffitt Date: Wed, 10 Jul 2013 15:03:47 -0600 Subject: [PATCH 1/2] Fix replaceFileIfMissing return value. --- src/components/script/dom/bindings/codegen/CodegenRust.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/components/script/dom/bindings/codegen/CodegenRust.py b/src/components/script/dom/bindings/codegen/CodegenRust.py index 055cb0ce488..5ae7091814b 100644 --- a/src/components/script/dom/bindings/codegen/CodegenRust.py +++ b/src/components/script/dom/bindings/codegen/CodegenRust.py @@ -39,6 +39,8 @@ def replaceFileIfChanged(filename, newContents): f.write(newContents) f.close() + return True + def toStringBool(arg): return str(not not arg).lower() From ebbfde06f929a6bc592df3012a96f3e2e4a94d97 Mon Sep 17 00:00:00 2001 From: Jack Moffitt Date: Wed, 10 Jul 2013 15:04:18 -0600 Subject: [PATCH 2/2] Bindings gen touches output Rust files to prevent it from running every time. --- Makefile.in | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Makefile.in b/Makefile.in index 242e15aa7d7..ec8d12071fd 100644 --- a/Makefile.in +++ b/Makefile.in @@ -254,11 +254,13 @@ bindinggen_dependencies := $(addprefix $(BINDINGS_SRC)/, BindingGen.py Bindings. $(AUTOGEN_SRC_script): %Binding.rs: $(bindinggen_dependencies) \ %.webidl - PYTHONDONTWRITEBYTECODE=1 $(CFG_PYTHON2) $(BINDINGS_SRC)/pythonpath.py \ + @echo "Maybe generating $(shell basename $@)..." + $(Q)PYTHONDONTWRITEBYTECODE=1 $(CFG_PYTHON2) $(BINDINGS_SRC)/pythonpath.py \ -I$(BINDINGS_SRC)/parser -I$(BINDINGS_SRC)/ply \ -D$(BINDINGS_SRC) \ $(BINDINGS_SRC)/BindingGen.py rs \ $(BINDINGS_SRC)/Bindings.conf $*Binding $*.webidl + $(Q)touch $@ globalgen_dependencies := $(addprefix $(BINDINGS_SRC)/, GlobalGen.py Bindings.conf Configuration.py CodegenRust.py parser/WebIDL.py) $(CACHE_DIR)/.done @@ -268,7 +270,7 @@ $(CACHE_DIR)/.done: $(BINDINGS_SRC)/ParserResults.pkl: $(globalgen_dependencies) \ $(WEBIDL_script) - PYTHONDONTWRITEBYTECODE=1 $(CFG_PYTHON2) $(BINDINGS_SRC)/pythonpath.py \ + $(Q)PYTHONDONTWRITEBYTECODE=1 $(CFG_PYTHON2) $(BINDINGS_SRC)/pythonpath.py \ -I$(BINDINGS_SRC)/parser -I$(BINDINGS_SRC)/ply \ -D$(BINDINGS_SRC) \ $(BINDINGS_SRC)/GlobalGen.py $(BINDINGS_SRC)/Bindings.conf . \