Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-05 05:30:08 +01:00
Code Issues Projects Releases Packages Wiki Activity

Implement Navigator.appVersion(#5409)

Browse source
This commit is contained in:
Deokjin Kim 2015-03-30 22:00:59 +09:00
parent 1bd8e18d92
commit c0e691b08d
7 changed files with 14 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

4
components/script/dom/navigator.rs
View file

@ -54,5 +54,9 @@ impl<'a> NavigatorMethods for JSRef<'a, Navigator> {
fn UserAgent(self) -> DOMString { fn UserAgent(self) -> DOMString {
navigatorinfo::UserAgent() navigatorinfo::UserAgent()
} }
fn AppVersion(self) -> DOMString {
navigatorinfo::AppVersion()
}
} }

4
components/script/dom/navigatorinfo.rs
View file

@ -33,3 +33,7 @@ pub fn UserAgent() -> DOMString {
None => "".to_owned(), None => "".to_owned(),
} }
} }
pub fn AppVersion() -> DOMString {
"4.0".to_owned()
}

2
components/script/dom/webidls/Navigator.webidl
View file

@ -19,7 +19,7 @@ Navigator implements NavigatorID;
interface NavigatorID { interface NavigatorID {
readonly attribute DOMString appCodeName; // constant "Mozilla" readonly attribute DOMString appCodeName; // constant "Mozilla"
readonly attribute DOMString appName; readonly attribute DOMString appName;
//readonly attribute DOMString appVersion; readonly attribute DOMString appVersion;
readonly attribute DOMString platform; readonly attribute DOMString platform;
readonly attribute DOMString product; // constant "Gecko" readonly attribute DOMString product; // constant "Gecko"
boolean taintEnabled(); // constant false boolean taintEnabled(); // constant false

4
components/script/dom/workernavigator.rs
View file

@ -55,5 +55,9 @@ impl<'a> WorkerNavigatorMethods for JSRef<'a, WorkerNavigator> {
fn UserAgent(self) -> DOMString { fn UserAgent(self) -> DOMString {
navigatorinfo::UserAgent() navigatorinfo::UserAgent()
} }
fn AppVersion(self) -> DOMString {
navigatorinfo::AppVersion()
}
} }

1
tests/content/test_navigator.html
View file

@ -14,6 +14,7 @@ is(nav.taintEnabled(), false);
is(nav.appName, "Netscape"); is(nav.appName, "Netscape");
is(nav.appCodeName, "Mozilla"); is(nav.appCodeName, "Mozilla");
is(nav.platform, ""); is(nav.platform, "");
is(nav.appVersion, "4.0");
</script> </script>
</body> </body>
</html> </html>

9
tests/wpt/metadata/html/dom/interfaces.html.ini
View file

@ -8637,9 +8637,6 @@
[Navigator interface object length] [Navigator interface object length]
expected: FAIL expected: FAIL
[Navigator interface: attribute appVersion]
expected: FAIL
[Navigator interface: attribute language] [Navigator interface: attribute language]
expected: FAIL expected: FAIL
@ -8682,9 +8679,6 @@
[Navigator interface: attribute javaEnabled] [Navigator interface: attribute javaEnabled]
expected: FAIL expected: FAIL
[Navigator interface: window.navigator must inherit property "appVersion" with the proper type (2)]
expected: FAIL
[Navigator interface: window.navigator must inherit property "language" with the proper type (7)] [Navigator interface: window.navigator must inherit property "language" with the proper type (7)]
expected: FAIL expected: FAIL
@ -9231,9 +9225,6 @@
[WorkerNavigator interface object length] [WorkerNavigator interface object length]
expected: FAIL expected: FAIL
[WorkerNavigator interface: attribute appVersion]
expected: FAIL
[WorkerNavigator interface: attribute language] [WorkerNavigator interface: attribute language]
expected: FAIL expected: FAIL

6
tests/wpt/metadata/workers/interfaces.worker.js.ini
View file

@ -81,9 +81,6 @@
[WorkerNavigator interface object length] [WorkerNavigator interface object length]
expected: FAIL expected: FAIL
[WorkerNavigator interface: attribute appVersion]
expected: FAIL
[WorkerNavigator interface: attribute language] [WorkerNavigator interface: attribute language]
expected: FAIL expected: FAIL
@ -93,9 +90,6 @@
[WorkerNavigator interface: attribute onLine] [WorkerNavigator interface: attribute onLine]
expected: FAIL expected: FAIL
[WorkerNavigator interface: self.navigator must inherit property "appVersion" with the proper type (2)]
expected: FAIL
[WorkerNavigator interface: self.navigator must inherit property "language" with the proper type (7)] [WorkerNavigator interface: self.navigator must inherit property "language" with the proper type (7)]
expected: FAIL expected: FAIL