From c15fa8bf25728ccc295b288770331ae97695fec2 Mon Sep 17 00:00:00 2001 From: Ms2ger Date: Wed, 16 Mar 2016 14:47:26 +0100 Subject: [PATCH] Use call rather than check_call in jquery_test_runner. The contract for mach commands is to return zero / non-zero to indicate success / failure, rather than throwing an exception. Since run_jquery.py uses a 1 exit code when there are unexpected results, this would cause an exception from check_call, which would then be printed with a stack trace. --- python/servo/testing_commands.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/python/servo/testing_commands.py b/python/servo/testing_commands.py index ddd8cc90918..7d76ad80e65 100644 --- a/python/servo/testing_commands.py +++ b/python/servo/testing_commands.py @@ -497,8 +497,7 @@ class MachCommands(CommandBase): # Check that a release servo build exists bin_path = path.abspath(self.get_binary_path(release, dev)) - return check_call( - [run_file, cmd, bin_path, base_dir]) + return call([run_file, cmd, bin_path, base_dir]) def dromaeo_test_runner(self, tests, release, dev): self.ensure_bootstrapped()