From 93717356f1207b4761780d2ca4aad2ef5f54901b Mon Sep 17 00:00:00 2001 From: Simon Sapin Date: Tue, 31 Oct 2017 22:13:19 +0100 Subject: [PATCH] Check full triples for "alt" compiler support, not just platforms. Fixes https://github.com/servo/servo/issues/19075 --- python/servo/command_base.py | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/python/servo/command_base.py b/python/servo/command_base.py index 77bb88886fa..7dbbaa701a0 100644 --- a/python/servo/command_base.py +++ b/python/servo/command_base.py @@ -23,7 +23,7 @@ from mach.registrar import Registrar import toml from servo.packages import WINDOWS_MSVC as msvc_deps -from servo.util import host_triple, host_platform +from servo.util import host_triple BIN_SUFFIX = ".exe" if sys.platform == "win32" else "" @@ -261,9 +261,13 @@ class CommandBase(object): self.config["tools"].setdefault("rustc-with-gold", get_env_bool("SERVO_RUSTC_WITH_GOLD", True)) # https://github.com/rust-lang/rust/pull/39754 - platforms_with_rustc_alt_builds = ["unknown-linux-gnu", "apple-darwin", "pc-windows-msvc"] + triples_with_rustc_alt_builds = [ + "x86_64-unknown-linux-gnu", + "x86_64-apple-darwin", + "x86_64-pc-windows-msvc", + ] llvm_assertions_default = ("SERVO_RUSTC_LLVM_ASSERTIONS" in os.environ - or host_platform() not in platforms_with_rustc_alt_builds) + or host_triple() not in triples_with_rustc_alt_builds) self.config.setdefault("build", {}) self.config["build"].setdefault("android", False)