Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-04 13:10:20 +01:00
Code Issues Projects Releases Packages Wiki Activity

Clarify some FIXMEs and bail out if we fail pushing data to player

Browse source
This commit is contained in:
Fernando Jiménez Moreno 2018-09-04 09:37:29 +02:00
parent 3fbeb398d4
commit c1bd551b11
1 changed files with 14 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

17
components/script/dom/htmlmediaelement.rs
View file

@ -602,7 +602,7 @@ impl HTMLMediaElement {
}, },
Mode::Children(_source) => { Mode::Children(_source) => {
// Step 9.children. // Step 9.children.
// FIXME(victor): seems not implemeted yet // FIXME: https://github.com/servo/servo/issues/21481
self.queue_dedicated_media_source_failure_steps() self.queue_dedicated_media_source_failure_steps()
}, },
} }
@ -1187,9 +1187,10 @@ impl FetchResponseListener for HTMLMediaElementContext {
let elem = self.elem.root(); let elem = self.elem.root();
// push input data into the player // Push input data into the player.
if let Err(_) = elem.player.push_data(payload) { if let Err(_) = elem.player.push_data(payload) {
eprintln!("Couldn't push input data to player"); eprintln!("Couldn't push input data to player");
return;
} }
// https://html.spec.whatwg.org/multipage/#concept-media-load-resource step 4, // https://html.spec.whatwg.org/multipage/#concept-media-load-resource step 4,
@ -1213,7 +1214,7 @@ impl FetchResponseListener for HTMLMediaElementContext {
} }
let elem = self.elem.root(); let elem = self.elem.root();
// signal the eos to player // Signal the eos to player.
if let Err(_) = elem.player.end_of_stream() { if let Err(_) = elem.player.end_of_stream() {
eprintln!("Couldn't signal EOS to player"); eprintln!("Couldn't signal EOS to player");
} }
@ -1221,7 +1222,15 @@ impl FetchResponseListener for HTMLMediaElementContext {
// => "If the media data can be fetched but is found by inspection to be in an unsupported // => "If the media data can be fetched but is found by inspection to be in an unsupported
// format, or can otherwise not be rendered at all" // format, or can otherwise not be rendered at all"
if !elem.have_metadata.get() { if !elem.have_metadata.get() {
// FIXME(victor): adjust player's max-size (or buffering) // FIXME(victor): adjust player's max-size (or buffering).
//
// In short streams the EOS might arrive before extracting the stream
// metadata. This is because the internal queue in the GStreamer appsrc element,
// has a size of 200K and it pushes the data until it is reached. It would be nice
// to add a property to set the max-data in appsrc according to reported size of
// the stream.
// Until then, we comment out the failure steps.
//
//elem.queue_dedicated_media_source_failure_steps(); //elem.queue_dedicated_media_source_failure_steps();
// => "Once the entire media resource has been fetched..." // => "Once the entire media resource has been fetched..."
} else if status.is_ok() { } else if status.is_ok() {