Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-06-10 09:33:13 +00:00
Code Issues Projects Releases Packages Wiki Activity

fix(script): the condition for exposing a cross-origin setter is CrossOriginWritable, not CrossOriginReadable

Browse source 
The expression `crossOriginIframe.contentWindow.location.href = "new
href"` takes the following steps: (1) Get the setter for `href` by
invoking `[[GetOwnProperty]]` on `crossOriginIframe.contentWindow.
location`. (2) Call the setter, passing `crossOriginIframe.
contentWindow` and `"new href"`. Since the target `Location` is cross
origin, getting the setter succeeds only if the `CrossOriginWritable`
extended attribute is present on the `href` attribute, and it's present.
However, instead of `CrossOriginWritable`, `CrossOriginReadable` was
checked mistakenly.

Since `Location#href` has `CrossOriginWritable` but not
`CrossOriginReadable`, this bug rendered `Location#href` inaccessible
from a cross-origin document.
This commit is contained in:
yvt 2021-08-17 01:45:55 +09:00
parent 8b3a49349d
commit c25355704d
2 changed files with 1 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

2
components/script/dom/bindings/codegen/CodegenRust.py
View file

@ -1936,7 +1936,7 @@ class AttrDefiner(PropertyDefiner):
def setter(attr): def setter(attr):
attr = attr['attr'] attr = attr['attr']
if ((self.crossorigin and not attr.getExtendedAttribute("CrossOriginReadable")) if ((self.crossorigin and not attr.getExtendedAttribute("CrossOriginWritable"))
or (attr.readonly or (attr.readonly
and not attr.getExtendedAttribute("PutForwards") and not attr.getExtendedAttribute("PutForwards")
and not attr.getExtendedAttribute("Replaceable"))): and not attr.getExtendedAttribute("Replaceable"))):

6
tests/wpt/metadata/html/browsers/origin/cross-origin-objects/cross-origin-objects.html.ini
View file

@ -188,12 +188,6 @@
[Same-origin observers get different accessors for cross-origin Window (cross-site)] [Same-origin observers get different accessors for cross-origin Window (cross-site)]
expected: FAIL expected: FAIL
[Same-origin observers get different accessors for cross-origin Location (cross-origin)]
expected: FAIL
[Same-origin observers get different accessors for cross-origin Location (same-origin + document.domain)]
expected: FAIL
[Same-origin observers get different accessors for cross-origin Location (cross-site)] [Same-origin observers get different accessors for cross-origin Location (cross-site)]
expected: FAIL expected: FAIL