Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-07-23 07:13:52 +01:00
Code Issues Projects Releases Packages Wiki Activity

disallow restricted XMLHttpRequest header prefixes

Browse source
This commit is contained in:
Chandler Abraham 2016-01-18 18:04:21 -08:00 • committed by Josh Matthews
parent aaad24c531
commit c375ad5e95
3 changed files with 20 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

32
components/script/dom/xmlhttprequest.rs
View file

@ -423,20 +423,26 @@ impl XMLHttpRequestMethods for XMLHttpRequest {
let name_lower = name.to_lower();
let name_str = match name_lower.as_str() {
Some(s) => {
match s {
// Step 5
// Disallowed headers
"accept-charset" | "accept-encoding" |
"access-control-request-headers" |
"access-control-request-method" |
"connection" | "content-length" |
"cookie" | "cookie2" | "date" |"dnt" |
"expect" | "host" | "keep-alive" | "origin" |
"referer" | "te" | "trailer" | "transfer-encoding" |
"upgrade" | "user-agent" | "via" => {
return Ok(());
},
_ => s
// Disallowed headers and header prefixes:
// https://www.w3.org/TR/XMLHttpRequest/#the-setrequestheader-method
let disallowedHeaders =
["accept-charset", "accept-encoding",
"access-control-request-headers",
"access-control-request-method",
"connection", "content-length",
"cookie", "cookie2", "date", "dnt",
"expect", "host", "keep-alive", "origin",
"referer", "te", "trailer", "transfer-encoding",
"upgrade", "user-agent", "via"];
let disallowedHeaderPrefixes = ["sec-", "proxy-"];
if disallowedHeaders.iter().any(|header| *header == s) ||
disallowedHeaderPrefixes.iter().any(|prefix| s.starts_with(prefix)) {
return Ok(())
} else {
s
}
},
None => unreachable!()

5
tests/wpt/metadata/XMLHttpRequest/setrequestheader-header-forbidden.htm.ini
View file

@ -1,5 +0,0 @@
[setrequestheader-header-forbidden.htm]
type: testharness
[XMLHttpRequest: setRequestHeader() - headers that are forbidden]
expected: FAIL

5
tests/wpt/metadata/websockets/security/002.html.ini
View file

@ -1,5 +0,0 @@
[002.html]
type: testharness
[WebSockets: check Sec-WebSocket-Key]
expected: FAIL