Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-11 08:25:32 +01:00
Code Issues Projects Releases Packages Wiki Activity

script: Rename DebuggerEvent to DebuggerAddDebuggeeEvent (#38571)

Browse source 
the next debugger script event, `getPossibleBreakpoints` (#37667), will
contain a single attribute `unsigned long spidermonkeyId`, so it will
have nothing in common with `addDebuggee`. this patch renames the latter
accordingly.

Testing: no behaviour changes other than the rename, so no tests needed
Fixes: part of #36027

Signed-off-by: Delan Azabani <dazabani@igalia.com>
This commit is contained in:
shuppy 2025-08-10 02:01:00 +08:00 • committed by GitHub
parent c49d53b8dd
commit c4044e17bb
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 10 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

8
components/script/dom/debuggerevent.rs → components/script/dom/debuggeradddebuggeeevent.rs
View file

@ -10,7 +10,7 @@ use script_bindings::conversions::SafeToJSValConvertible;
use script_bindings::reflector::DomObject; use script_bindings::reflector::DomObject;
use script_bindings::str::DOMString; use script_bindings::str::DOMString;
use crate::dom::bindings::codegen::Bindings::DebuggerEventBinding::DebuggerEventMethods; use crate::dom::bindings::codegen::Bindings::DebuggerAddDebuggeeEventBinding::DebuggerAddDebuggeeEventMethods;
use crate::dom::bindings::codegen::Bindings::EventBinding::Event_Binding::EventMethods; use crate::dom::bindings::codegen::Bindings::EventBinding::Event_Binding::EventMethods;
use crate::dom::bindings::reflector::reflect_dom_object; use crate::dom::bindings::reflector::reflect_dom_object;
use crate::dom::bindings::root::{Dom, DomRoot}; use crate::dom::bindings::root::{Dom, DomRoot};
@ -20,14 +20,14 @@ use crate::script_runtime::CanGc;
#[dom_struct] #[dom_struct]
/// Event for Rust → JS calls in [`crate::dom::DebuggerGlobalScope`]. /// Event for Rust → JS calls in [`crate::dom::DebuggerGlobalScope`].
pub(crate) struct DebuggerEvent { pub(crate) struct DebuggerAddDebuggeeEvent {
event: Event, event: Event,
global: Dom<GlobalScope>, global: Dom<GlobalScope>,
pipeline_id: Dom<PipelineId>, pipeline_id: Dom<PipelineId>,
worker_id: Option<DOMString>, worker_id: Option<DOMString>,
} }
impl DebuggerEvent { impl DebuggerAddDebuggeeEvent {
pub(crate) fn new( pub(crate) fn new(
debugger_global: &GlobalScope, debugger_global: &GlobalScope,
global: &GlobalScope, global: &GlobalScope,
@ -48,7 +48,7 @@ impl DebuggerEvent {
} }
} }
impl DebuggerEventMethods<crate::DomTypeHolder> for DebuggerEvent { impl DebuggerAddDebuggeeEventMethods<crate::DomTypeHolder> for DebuggerAddDebuggeeEvent {
// check-tidy: no specs after this line // check-tidy: no specs after this line
fn Global(&self, cx: script_bindings::script_runtime::JSContext) -> NonNull<JSObject> { fn Global(&self, cx: script_bindings::script_runtime::JSContext) -> NonNull<JSObject> {
// Convert the debuggee global’s reflector to a Value, wrapping it from its originating realm (debuggee realm) // Convert the debuggee global’s reflector to a Value, wrapping it from its originating realm (debuggee realm)

6
components/script/dom/debuggerglobalscope.rs
View file

@ -23,7 +23,7 @@ use crate::dom::bindings::inheritance::Castable;
use crate::dom::bindings::root::DomRoot; use crate::dom::bindings::root::DomRoot;
use crate::dom::bindings::utils::define_all_exposed_interfaces; use crate::dom::bindings::utils::define_all_exposed_interfaces;
use crate::dom::globalscope::GlobalScope; use crate::dom::globalscope::GlobalScope;
use crate::dom::types::{DebuggerEvent, Event}; use crate::dom::types::{DebuggerAddDebuggeeEvent, Event};
#[cfg(feature = "testbinding")] #[cfg(feature = "testbinding")]
#[cfg(feature = "webgpu")] #[cfg(feature = "webgpu")]
use crate::dom::webgpu::identityhub::IdentityHub; use crate::dom::webgpu::identityhub::IdentityHub;
@ -132,7 +132,7 @@ impl DebuggerGlobalScope {
) { ) {
let debuggee_pipeline_id = let debuggee_pipeline_id =
crate::dom::pipelineid::PipelineId::new(self.upcast(), debuggee_pipeline_id, can_gc); crate::dom::pipelineid::PipelineId::new(self.upcast(), debuggee_pipeline_id, can_gc);
let event = DomRoot::upcast::<Event>(DebuggerEvent::new( let event = DomRoot::upcast::<Event>(DebuggerAddDebuggeeEvent::new(
self.upcast(), self.upcast(),
debuggee_global, debuggee_global,
&debuggee_pipeline_id, &debuggee_pipeline_id,
@ -141,7 +141,7 @@ impl DebuggerGlobalScope {
)); ));
assert!( assert!(
DomRoot::upcast::<Event>(event).fire(self.upcast(), can_gc), DomRoot::upcast::<Event>(event).fire(self.upcast(), can_gc),
"Guaranteed by DebuggerEvent::new" "Guaranteed by DebuggerAddDebuggeeEvent::new"
); );
} }
} }

2
components/script/dom/mod.rs
View file

@ -289,7 +289,7 @@ pub(crate) mod customevent;
pub(crate) mod datatransfer; pub(crate) mod datatransfer;
pub(crate) mod datatransferitem; pub(crate) mod datatransferitem;
pub(crate) mod datatransferitemlist; pub(crate) mod datatransferitemlist;
pub(crate) mod debuggerevent; pub(crate) mod debuggeradddebuggeeevent;
pub(crate) mod debuggerglobalscope; pub(crate) mod debuggerglobalscope;
pub(crate) mod dedicatedworkerglobalscope; pub(crate) mod dedicatedworkerglobalscope;
pub(crate) mod defaultteereadrequest; pub(crate) mod defaultteereadrequest;

2
components/script/dom/pipelineid.rs
View file

@ -4,7 +4,7 @@
use dom_struct::dom_struct; use dom_struct::dom_struct;
use crate::dom::bindings::codegen::Bindings::DebuggerEventBinding::PipelineIdMethods; use crate::dom::bindings::codegen::Bindings::DebuggerAddDebuggeeEventBinding::PipelineIdMethods;
use crate::dom::bindings::reflector::{Reflector, reflect_dom_object}; use crate::dom::bindings::reflector::{Reflector, reflect_dom_object};
use crate::dom::bindings::root::DomRoot; use crate::dom::bindings::root::DomRoot;
use crate::dom::globalscope::GlobalScope; use crate::dom::globalscope::GlobalScope;

2
components/script_bindings/webidls/DebuggerEvent.webidl → components/script_bindings/webidls/DebuggerAddDebuggeeEvent.webidl
View file

@ -5,7 +5,7 @@
// This interface is entirely internal to Servo, and should not be accessible to // This interface is entirely internal to Servo, and should not be accessible to
// web pages. // web pages.
[Exposed=DebuggerGlobalScope] [Exposed=DebuggerGlobalScope]
interface DebuggerEvent : Event { interface DebuggerAddDebuggeeEvent : Event {
readonly attribute object global; readonly attribute object global;
readonly attribute PipelineId pipelineId; readonly attribute PipelineId pipelineId;
readonly attribute DOMString? workerId; readonly attribute DOMString? workerId;