Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 14:10:11 +01:00
Code Issues Projects Releases Packages Wiki Activity

Remove redundant .clone()s

Browse source
This commit is contained in:
Shotaro Yamada 2018-12-11 10:43:51 +09:00
parent eeaca0b26d
commit c44a2febe6
19 changed files with 31 additions and 35 deletions
Download patch file Download diff file Expand all files Collapse all files

18
components/constellation/constellation.rs
View file

@ -765,7 +765,7 @@ where
self.event_loops.get(&host).and_then(|weak| weak.upgrade());
match event_loop {
None => (None, Some(host)),
Some(event_loop) => (Some(event_loop.clone()), None),
Some(event_loop) => (Some(event_loop), None),
}
},
}
@ -1238,7 +1238,7 @@ where
},
None => "".to_owned(),
};
if let Err(e) = sender.send(contents.to_owned()) {
if let Err(e) = sender.send(contents) {
warn!("Failed to send clipboard ({})", e);
}
},
@ -1635,7 +1635,7 @@ where
None,
opener,
window_size,
load_data.clone(),
load_data,
sandbox,
is_private,
is_visible.unwrap_or(true),
@ -1716,7 +1716,7 @@ where
);
self.embedder_proxy.send(msg);
let browsing_context_id = BrowsingContextId::from(top_level_browsing_context_id);
let load_data = LoadData::new(url.clone(), None, None, None);
let load_data = LoadData::new(url, None, None, None);
let sandbox = IFrameSandboxState::IFrameUnsandboxed;
let is_private = false;
let is_visible = true;
@ -1738,7 +1738,7 @@ where
None,
None,
Some(window_size),
load_data.clone(),
load_data,
sandbox,
is_private,
is_visible,
@ -1909,7 +1909,7 @@ where
Some(parent_pipeline_id),
None,
browsing_context.size,
load_data.clone(),
load_data,
load_info.sandbox,
is_private,
browsing_context.is_visible,
@ -2235,7 +2235,7 @@ where
None,
opener,
window_size,
load_data.clone(),
load_data,
sandbox,
is_private,
is_visible,
@ -2555,7 +2555,7 @@ where
top_level_browsing_context_id: top_level_id,
browsing_context_id: browsing_context_id,
new_pipeline_id: new_pipeline_id,
replace: Some(NeedsToReload::Yes(pipeline_id, load_data.clone())),
replace: Some(NeedsToReload::Yes(pipeline_id, load_data)),
// Browsing context must exist at this point.
new_browsing_context_info: None,
});
@ -3190,7 +3190,7 @@ where
.future
.iter()
.rev()
.scan(current_load_data.clone(), &resolve_load_data_future),
.scan(current_load_data, &resolve_load_data_future),
);
let urls = entries.iter().map(|entry| entry.url.clone()).collect();
let msg = (

2
components/constellation/network_listener.rs
View file

@ -129,7 +129,7 @@ impl NetworkListener {
_ => {
// Response should be processed by script thread.
self.should_send = true;
self.send(FetchResponseMsg::ProcessResponse(Ok(res_metadata.clone())));
self.send(FetchResponseMsg::ProcessResponse(Ok(res_metadata)));
},
};
},

6
components/constellation/pipeline.rs
View file

@ -219,9 +219,7 @@ impl Pipeline {
load_data: state.load_data.clone(),
window_size: window_size,
pipeline_port: pipeline_port,
content_process_shutdown_chan: Some(
layout_content_process_shutdown_chan.clone(),
),
content_process_shutdown_chan: Some(layout_content_process_shutdown_chan),
layout_threads: PREFS.get("layout.threads").as_u64().expect("count") as usize,
};
@ -552,7 +550,7 @@ impl UnprivilegedPipelineContent {
background_hang_monitor_register,
self.layout_to_constellation_chan,
self.script_chan,
image_cache.clone(),
image_cache,
self.font_cache_thread,
self.time_profiler_chan,
self.mem_profiler_chan,