Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-03 12:40:06 +01:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #29646 - CYBAI:fix-classname-filter, r=jdm

Browse source 
Fix checking for empty set in getElementsByClassName

Because empty set with `.all(predicate)` will always return `true`, it will result in always filtering wrong elements when the classes is empty set.

Thus, we return earlier with `always_empty` HTMLCollection in the empty classes case so that we can avoid filtering on empty sets.

With adding the checking, we can fix the failures in `/dom/nodes/getElementsByClassName-empty-set.html`.

---

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)
- [x] There are tests for these changes
This commit is contained in:
bors-servo 2023-04-24 07:55:25 +02:00 • committed by GitHub
commit c44c6e8c11
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

6
components/script/dom/htmlcollection.rs
View file

@ -252,11 +252,17 @@ impl HTMLCollection {
let case_sensitivity = document_from_node(elem) let case_sensitivity = document_from_node(elem)
.quirks_mode() .quirks_mode()
.classes_and_ids_case_sensitivity(); .classes_and_ids_case_sensitivity();
self.classes self.classes
.iter() .iter()
.all(|class| elem.has_class(class, case_sensitivity)) .all(|class| elem.has_class(class, case_sensitivity))
} }
} }
if classes.is_empty() {
return HTMLCollection::always_empty(window, root);
}
let filter = ClassNameFilter { classes: classes }; let filter = ClassNameFilter { classes: classes };
HTMLCollection::create(window, root, Box::new(filter)) HTMLCollection::create(window, root, Box::new(filter))
} }

10
tests/wpt/metadata/dom/nodes/getElementsByClassName-empty-set.html.ini
View file

@ -1,10 +0,0 @@
[getElementsByClassName-empty-set.html]
[Passing a space to getElementsByClassName should return an empty HTMLCollection]
expected: FAIL
[Passing three spaces to getElementsByClassName should return an empty HTMLCollection]
expected: FAIL
[Passing an empty string to getElementsByClassName should return an empty HTMLCollection]
expected: FAIL