Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-05 05:30:08 +01:00
Code Issues Projects Releases Packages Wiki Activity

Remove lock around tokio-rt handle (#36762)

Browse source 
It seems sub-optimal to to sequentialise execution by grabbing a lock,
each time we want to spawn a task onto the tokio runtime. We don't need
the lock either, so it makes sense to just remove it, which also
simplifies a bunch of the using code.

Testing: Covered by existing tests

Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
This commit is contained in:
Jonathan Schwender 2025-04-30 09:09:38 +02:00 • committed by GitHub
parent 955149b194
commit c46402e222
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 37 additions and 44 deletions
Download patch file Download diff file Expand all files Collapse all files

4
components/net/http_loader.rs
View file

@ -493,7 +493,7 @@ impl BodySink {
match self {
BodySink::Chunked(sender) => {
let sender = sender.clone();
HANDLE.lock().unwrap().as_mut().unwrap().spawn(async move {
HANDLE.spawn(async move {
let _ = sender.send(Ok(Frame::data(bytes.into()))).await;
});
},
@ -2016,7 +2016,7 @@ async fn http_network_fetch(
let url1 = request.url();
let url2 = url1.clone();
HANDLE.lock().unwrap().as_ref().unwrap().spawn(
HANDLE.spawn(
res.into_body()
.map_err(|e| {
warn!("Error streaming response body: {:?}", e);