Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-12 08:55:32 +01:00
Code Issues Projects Releases Packages Wiki Activity

layout: Paint flex and grid items like inline blocks (#38574)

Browse source 
As specified in https://drafts.csswg.org/css-flexbox-1/#painting and
https://drafts.csswg.org/css-grid/#z-order

Testing: Makes some WPT pass.
Fixes: #38573

Signed-off-by: Oriol Brufau <obrufau@igalia.com>
This commit is contained in:
Oriol Brufau 2025-08-09 10:42:12 -07:00 • committed by GitHub
parent 7b057be780
commit c49d53b8dd
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
10 changed files with 6 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

8
components/layout/display_list/stacking_context.rs
View file

@ -930,7 +930,8 @@ struct OverflowFrameData {
impl BoxFragment {
fn get_stacking_context_type(&self) -> Option<StackingContextType> {
if self.style.establishes_stacking_context(self.base.flags) {
let flags = self.base.flags;
if self.style.establishes_stacking_context(flags) {
return Some(StackingContextType::RealStackingContext);
}
@ -943,7 +944,10 @@ impl BoxFragment {
return Some(StackingContextType::FloatStackingContainer);
}
if self.is_atomic_inline_level() {
// Flex and grid items are painted like inline blocks.
// <https://drafts.csswg.org/css-flexbox-1/#painting>
// <https://drafts.csswg.org/css-grid/#z-order>
if self.is_atomic_inline_level() || flags.contains(FragmentFlags::IS_FLEX_OR_GRID_ITEM) {
return Some(StackingContextType::AtomicInlineStackingContainer);
}

2
tests/wpt/meta/css/css-flexbox/flexbox-items-as-stacking-contexts-002.html.ini vendored
View file

@ -1,2 +0,0 @@
[flexbox-items-as-stacking-contexts-002.html]
expected: FAIL

3
tests/wpt/meta/css/css-flexbox/flexbox-mbp-horiz-003-reverse.xhtml.ini vendored
View file

@ -1,3 +0,0 @@
[flexbox-mbp-horiz-003-reverse.xhtml]
expected:
if os == "linux": FAIL

3
tests/wpt/meta/css/css-flexbox/flexbox-mbp-horiz-003.xhtml.ini vendored
View file

@ -1,3 +0,0 @@
[flexbox-mbp-horiz-003.xhtml]
expected:
if os == "linux": FAIL

3
tests/wpt/meta/css/css-flexbox/flexbox-mbp-horiz-003v.xhtml.ini vendored
View file

@ -1,3 +0,0 @@
[flexbox-mbp-horiz-003v.xhtml]
expected:
if os == "linux": FAIL

4
tests/wpt/meta/css/css-flexbox/hittest-overlapping-margin.html.ini vendored
View file

@ -1,4 +0,0 @@
[hittest-overlapping-margin.html]
[Flexboxes should perform hit testing in reverse paint order for overlapping elements: negative margin case (crbug.com/844505)]
expected: FAIL

4
tests/wpt/meta/css/css-flexbox/hittest-overlapping-order.html.ini vendored
View file

@ -1,4 +0,0 @@
[hittest-overlapping-order.html]
[Flexboxes should perform hit testing in reverse paint order for overlapping elements: flex order case (crbug.com/844505)]
expected: FAIL

2
tests/wpt/meta/css/css-grid/grid-items/grid-inline-items-inline-blocks-001.html.ini vendored
View file

@ -1,2 +0,0 @@
[grid-inline-items-inline-blocks-001.html]
expected: FAIL

2
tests/wpt/meta/css/css-grid/grid-items/grid-items-inline-blocks-001.html.ini vendored
View file

@ -1,2 +0,0 @@
[grid-items-inline-blocks-001.html]
expected: FAIL

3
tests/wpt/meta/css/css-grid/grid-model/grid-item-hit-test.html.ini vendored
View file

@ -1,3 +0,0 @@
[grid-item-hit-test.html]
[grid-item-hit-test]
expected: FAIL