mirror of
https://github.com/servo/servo.git
synced 2025-08-07 06:25:32 +01:00
Auto merge of #18355 - servo:no-fmt, r=emilio
Reduce usage of fmt in serialization and error reporting `format!` and `write!` create a somewhat-heavyweight `Formatting` struct and use dynamic dispatch to call into impls of `Dispaly` and related traits. The former also allocates an intermediate string that is sometimes unnecessary. I started looking into this from https://bugzilla.mozilla.org/show_bug.cgi?id=1355599, but I expect the impact there will be small to insignificant. It might be a slightly less so on parsing (error reporting). <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18355) <!-- Reviewable:end -->
This commit is contained in:
commit
c60dd53210
27 changed files with 328 additions and 365 deletions
|
@ -399,7 +399,9 @@ impl MediaExpressionValue {
|
|||
dest.write_str(if v { "1" } else { "0" })
|
||||
},
|
||||
MediaExpressionValue::IntRatio(a, b) => {
|
||||
write!(dest, "{}/{}", a, b)
|
||||
a.to_css(dest)?;
|
||||
dest.write_char('/')?;
|
||||
b.to_css(dest)
|
||||
},
|
||||
MediaExpressionValue::Resolution(ref r) => r.to_css(dest),
|
||||
MediaExpressionValue::Ident(ref ident) => {
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue