From c641c589e5f18e461887bdb67528425fe683715d Mon Sep 17 00:00:00 2001 From: Martin Robinson Date: Thu, 18 Jan 2024 17:12:04 +0100 Subject: [PATCH] build: Use `--keep-going` in `./mach doc` (#31119) The documentation build for `gstreamer-gl-x11` depends on nightly Rust for some reason, which breaks our doc build. Use `--keep-going` to prevent breakage in dependencies from breaking our doc build. This unfortunately hides issues in our own documentation build. NB: It isn't possible to exclude dependencies with `--exclude` unless you are using `--workspace`. We would probably like to do that, but we have crates with the same name, preventing using `--workspace`. --- python/servo/post_build_commands.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/python/servo/post_build_commands.py b/python/servo/post_build_commands.py index 0af43c9f199..bd9382b55a1 100644 --- a/python/servo/post_build_commands.py +++ b/python/servo/post_build_commands.py @@ -266,6 +266,11 @@ class PostBuildCommands(CommandBase): else: copy2(full_name, destination) + # Documentation build errors shouldn't cause the entire build to fail. This + # prevents issues with dependencies from breaking our documentation build, + # with the downside that it hides documentation issues. + params.insert(0, "--keep-going") + env = self.build_env() returncode = self.run_cargo_build_like_command("doc", params, env=env, **kwargs) if returncode: