Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-05 05:30:08 +01:00
Code Issues Projects Releases Packages Wiki Activity

Eliminate an unnecessary heap allocation.

Browse source 
MozReview-Commit-ID: 4cleAH0JsKK
This commit is contained in:
Bobby Holley 2017-06-08 16:34:09 -07:00
parent f04c25c33c
commit c6d0ef5e9f
1 changed files with 6 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

11
components/style/parallel.rs
View file

@ -41,8 +41,8 @@ pub const WORK_UNIT_MAX: usize = 16;
/// A list of node pointers. /// A list of node pointers.
/// ///
/// Note that the inline storage doesn't need to be sized to WORK_UNIT_MAX, but /// We make the inline storage size WORK_UNIT_MAX so that we can collect chunks
/// it generally seems sensible to do so. /// into this structure without heap-allocating.
type NodeList<N> = SmallVec<[SendNode<N>; WORK_UNIT_MAX]>; type NodeList<N> = SmallVec<[SendNode<N>; WORK_UNIT_MAX]>;
/// Entry point for the parallel traversal. /// Entry point for the parallel traversal.
@ -263,11 +263,12 @@ fn traverse_nodes<'a, 'scope, E, D>(nodes: NodeList<E::ConcreteNode>,
} }
} else { } else {
for chunk in nodes.chunks(WORK_UNIT_MAX) { for chunk in nodes.chunks(WORK_UNIT_MAX) {
let boxed = chunk.iter().cloned().collect::<Vec<_>>().into_boxed_slice(); let nodes = chunk.iter().cloned().collect::<NodeList<E::ConcreteNode>>();
debug_assert!(!nodes.spilled());
let traversal_data_copy = traversal_data.clone(); let traversal_data_copy = traversal_data.clone();
scope.spawn(move |scope| { scope.spawn(move |scope| {
let b = boxed; let n = nodes;
top_down_dom(&*b, root, traversal_data_copy, scope, pool, traversal, tls) top_down_dom(&*n, root, traversal_data_copy, scope, pool, traversal, tls)
}); });
} }
} }