From 4c3a6b839b16ec30f2ef3160b3ab15925cc5f860 Mon Sep 17 00:00:00 2001 From: Matt Brubeck Date: Fri, 24 Jul 2015 13:51:59 -0700 Subject: [PATCH] Perform argument validation before bootstrapping. If there's an error in the command-line arguments for `mach build`, we should print it before starting a (potentially) long bootstrap process, not after. --- python/servo/build_commands.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/python/servo/build_commands.py b/python/servo/build_commands.py index dd2fbb52c8e..12f0c909ddd 100644 --- a/python/servo/build_commands.py +++ b/python/servo/build_commands.py @@ -142,8 +142,6 @@ class MachCommands(CommandBase): help="Command-line arguments to be passed through to Cargo") def build(self, target=None, release=False, dev=False, jobs=None, android=None, verbose=False, debug_mozjs=False, params=None): - self.ensure_bootstrapped() - if android is None: android = self.config["build"]["android"] @@ -175,6 +173,8 @@ class MachCommands(CommandBase): print("Please specify either --dev or --release.") sys.exit(1) + self.ensure_bootstrapped() + if release: opts += ["--release"] if target: