diff --git a/components/script/dom/bindings/codegen/CodegenRust.py b/components/script/dom/bindings/codegen/CodegenRust.py index 01efdd012c0..35e3a05d2d0 100644 --- a/components/script/dom/bindings/codegen/CodegenRust.py +++ b/components/script/dom/bindings/codegen/CodegenRust.py @@ -3836,14 +3836,14 @@ if expando.is_not_null() { getIndexedOrExpando = getFromExpando + "\n" namedGetter = self.descriptor.operations['NamedGetter'] - if namedGetter and False: #XXXjdm unfinished - getNamed = ("if (JSID_IS_STRING(id)) {\n" + + if namedGetter: + getNamed = ("if (RUST_JSID_IS_STRING(id) != 0) {\n" + " let name = jsid_to_str(cx, id);\n" + " let this = UnwrapProxy(proxy);\n" + " let this = JS::from_raw(this);\n" + " let this = this.root();\n" + CGIndenter(CGProxyNamedGetter(self.descriptor, templateValues)).define() + - "}\n") % (self.descriptor.concreteType) + "}\n") else: getNamed = "" diff --git a/tests/wpt/metadata/dom/nodes/Document-getElementsByTagName.html.ini b/tests/wpt/metadata/dom/nodes/Document-getElementsByTagName.html.ini index 5b48891daad..292b75271e0 100644 --- a/tests/wpt/metadata/dom/nodes/Document-getElementsByTagName.html.ini +++ b/tests/wpt/metadata/dom/nodes/Document-getElementsByTagName.html.ini @@ -1,8 +1,3 @@ [Document-getElementsByTagName.html] type: testharness - [Shouldn\'t be able to set unsigned properties on a HTMLCollection (strict mode)] - expected: FAIL - - [hasOwnProperty, getOwnPropertyDescriptor, getOwnPropertyNames] - expected: FAIL - + expected: CRASH diff --git a/tests/wpt/metadata/dom/nodes/Element-getElementsByTagName.html.ini b/tests/wpt/metadata/dom/nodes/Element-getElementsByTagName.html.ini index e7df74ba227..d1240410583 100644 --- a/tests/wpt/metadata/dom/nodes/Element-getElementsByTagName.html.ini +++ b/tests/wpt/metadata/dom/nodes/Element-getElementsByTagName.html.ini @@ -1,7 +1,3 @@ [Element-getElementsByTagName.html] type: testharness - [Shouldn\'t be able to set unsigned properties on a HTMLCollection (strict mode)] - expected: FAIL - - [hasOwnProperty, getOwnPropertyDescriptor, getOwnPropertyNames] - expected: FAIL + expected: CRASH diff --git a/tests/wpt/metadata/html/dom/documents/dom-tree-accessors/document.images.html.ini b/tests/wpt/metadata/html/dom/documents/dom-tree-accessors/document.images.html.ini deleted file mode 100644 index 37986ac7c73..00000000000 --- a/tests/wpt/metadata/html/dom/documents/dom-tree-accessors/document.images.html.ini +++ /dev/null @@ -1,17 +0,0 @@ -[document.images.html] - type: testharness - [img with id] - expected: FAIL - - [img with name] - expected: FAIL - - [img with id and name] - expected: FAIL - - [Two img elements with the same id] - expected: FAIL - - [Two img elements with the same name] - expected: FAIL - diff --git a/tests/wpt/metadata/html/semantics/forms/the-button-element/button-events.html.ini b/tests/wpt/metadata/html/semantics/forms/the-button-element/button-events.html.ini index fee05396743..0267bcc8560 100644 --- a/tests/wpt/metadata/html/semantics/forms/the-button-element/button-events.html.ini +++ b/tests/wpt/metadata/html/semantics/forms/the-button-element/button-events.html.ini @@ -2,11 +2,11 @@ type: testharness expected: TIMEOUT [The submit event must be fired when click a button in submit status] - expected: NOTRUN + expected: TIMEOUT [The reset event must be fired when click a button in reset status] - expected: NOTRUN + expected: TIMEOUT [The show event must be fired when click a button in menu status] - expected: NOTRUN + expected: TIMEOUT diff --git a/tests/wpt/metadata/html/semantics/forms/the-fieldset-element/HTMLFieldSetElement.html.ini b/tests/wpt/metadata/html/semantics/forms/the-fieldset-element/HTMLFieldSetElement.html.ini index 32e084e0c78..d8668a3b537 100644 --- a/tests/wpt/metadata/html/semantics/forms/the-fieldset-element/HTMLFieldSetElement.html.ini +++ b/tests/wpt/metadata/html/semantics/forms/the-fieldset-element/HTMLFieldSetElement.html.ini @@ -9,3 +9,6 @@ [The controls must root at the fieldset element] expected: FAIL + [The form attribute must return the fieldset\'s form owner] + expected: FAIL + diff --git a/tests/wpt/metadata/html/semantics/forms/the-input-element/password.html.ini b/tests/wpt/metadata/html/semantics/forms/the-input-element/password.html.ini index c5b79f2fd5f..98cc912d3f4 100644 --- a/tests/wpt/metadata/html/semantics/forms/the-input-element/password.html.ini +++ b/tests/wpt/metadata/html/semantics/forms/the-input-element/password.html.ini @@ -5,3 +5,4 @@ [sanitization algorithm strips line breaks] expected: FAIL + diff --git a/tests/wpt/metadata/html/semantics/forms/the-input-element/reset.html.ini b/tests/wpt/metadata/html/semantics/forms/the-input-element/reset.html.ini index 9bc56e188a3..20a3f17079a 100644 --- a/tests/wpt/metadata/html/semantics/forms/the-input-element/reset.html.ini +++ b/tests/wpt/metadata/html/semantics/forms/the-input-element/reset.html.ini @@ -8,3 +8,4 @@ [reset button resets controls associated with a form using the form attribute] expected: FAIL + diff --git a/tests/wpt/metadata/webstorage/storage_session_clear_js.html.ini b/tests/wpt/metadata/webstorage/storage_session_clear_js.html.ini deleted file mode 100644 index 68207e3a95c..00000000000 --- a/tests/wpt/metadata/webstorage/storage_session_clear_js.html.ini +++ /dev/null @@ -1,5 +0,0 @@ -[storage_session_clear_js.html] - type: testharness - [Web Storage] - expected: FAIL - diff --git a/tests/wpt/metadata/webstorage/storage_session_getitem_js.html.ini b/tests/wpt/metadata/webstorage/storage_session_getitem_js.html.ini deleted file mode 100644 index bfa36046966..00000000000 --- a/tests/wpt/metadata/webstorage/storage_session_getitem_js.html.ini +++ /dev/null @@ -1,5 +0,0 @@ -[storage_session_getitem_js.html] - type: testharness - [array access should be correct] - expected: FAIL - diff --git a/tests/wpt/metadata/webstorage/storage_session_setitem_js.html.ini b/tests/wpt/metadata/webstorage/storage_session_setitem_js.html.ini index 7486cce7dc6..cfb08cb88fd 100644 --- a/tests/wpt/metadata/webstorage/storage_session_setitem_js.html.ini +++ b/tests/wpt/metadata/webstorage/storage_session_setitem_js.html.ini @@ -9,9 +9,6 @@ [Web Storage 4] expected: FAIL - [Web Storage 5] - expected: FAIL - [Web Storage 6] expected: FAIL @@ -27,15 +24,9 @@ [Web Storage 10] expected: FAIL - [Web Storage 11] - expected: FAIL - [Web Storage 12] expected: FAIL - [Web Storage 13] - expected: FAIL - [Web Storage 14] expected: FAIL