Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-05 21:50:18 +01:00
Code Issues Projects Releases Packages Wiki Activity

clarify and test interactions with indexed access

Browse source
This commit is contained in:
Delan Azabani 2023-03-21 14:06:05 +08:00
parent fb2acb0b02
commit c831a136b2
2 changed files with 53 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
components/script/window_named_properties.rs
View file

@ -117,14 +117,14 @@ unsafe extern "C" fn get_own_property_descriptor(
jsstr_to_string(*cx, id.to_string())
} else if id.is_int() {
// If the property key is an integer index, convert it to a String too.
// TODO(delan) will this interfere with indexed access on the Window object
// (window[index]), which should only return document-tree child navigables?
// https://html.spec.whatwg.org/multipage/#accessing-other-browsing-contexts
// For indexed access on the window object, which may shadow this, see
// the getOwnPropertyDescriptor trap in dom/windowproxy.rs.
id.to_int().to_string()
} else if id.is_symbol() {
// Symbol properties were already handled above.
unreachable!()
} else {
unreachable!()
unimplemented!()
};
if s.is_empty() {
return true;