Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-06-06 16:45:39 +00:00
Code Issues Projects Releases Packages Wiki Activity

preferences actor now returns real values.

Browse source 
The preferences actor was previously returning mock values. This changes
picks up the pref_values from the pref_map which is global preferences
state and returns values from there.
This commit is contained in:
Sudarsan 2020-09-12 18:55:11 +08:00
parent a5a21a59ad
commit c8d911817f
1 changed files with 33 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

52
components/devtools/actors/preference.rs
View file

@ -6,6 +6,8 @@ use crate::actor::{Actor, ActorMessageStatus, ActorRegistry};
use crate::protocol::JsonPacketStream;
use crate::StreamId;
use serde_json::{Map, Value};
use servo_config::pref_util::PrefValue;
use servo_config::prefs::pref_map;
use std::net::TcpStream;
pub struct PreferenceActor {
@ -31,35 +33,41 @@ impl Actor for PreferenceActor {
stream: &mut TcpStream,
_id: StreamId,
) -> Result<ActorMessageStatus, ()> {
Ok(match msg_type {
"getBoolPref" => {
let reply = BoolReply {
let pref_value = pref_map().get(msg_type);
Ok(match pref_value {
PrefValue::Float(value) => {
let reply = FloatReply {
from: self.name(),
value: false,
value: value,
};
let _ = stream.write_json_packet(&reply);
ActorMessageStatus::Processed
},
"getCharPref" => {
let reply = CharReply {
from: self.name(),
value: "".to_owned(),
};
let _ = stream.write_json_packet(&reply);
ActorMessageStatus::Processed
},
"getIntPref" => {
PrefValue::Int(value) => {
let reply = IntReply {
from: self.name(),
value: 0,
value: value,
};
let _ = stream.write_json_packet(&reply);
ActorMessageStatus::Processed
},
_ => ActorMessageStatus::Ignored,
PrefValue::Str(value) => {
let reply = CharReply {
from: self.name(),
value: value,
};
let _ = stream.write_json_packet(&reply);
ActorMessageStatus::Processed
},
PrefValue::Bool(value) => {
let reply = BoolReply {
from: self.name(),
value: value,
};
let _ = stream.write_json_packet(&reply);
ActorMessageStatus::Processed
},
PrefValue::Missing => ActorMessageStatus::Ignored,
})
}
}
@ -79,5 +87,11 @@ struct CharReply {
#[derive(Serialize)]
struct IntReply {
from: String,
value: i32,
value: i64,
}
#[derive(Serialize)]
struct FloatReply {
from: String,
value: f64,
}