Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 06:00:15 +01:00
Code Issues Projects Releases Packages Wiki Activity

add CanGc as argument to methods in Element (#36464)

Browse source 
add CanGc as argument to methods in Element

Testing: These changes do not require tests because they are a refactor.
Addresses part of https://github.com/servo/servo/issues/34573.

Signed-off-by: Yerkebulan Tulibergenov <yerkebulan@gmail.com>
This commit is contained in:
Yerkebulan Tulibergenov 2025-04-10 23:21:50 -07:00 • committed by GitHub
parent 3c5da6588d
commit c8ecb57d97
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
9 changed files with 61 additions and 52 deletions
Download patch file Download diff file Expand all files Collapse all files

6
components/script/dom/htmlelement.rs
View file

@ -594,7 +594,7 @@ impl HTMLElementMethods<crate::DomTypeHolder> for HTMLElement {
false
}
/// <https://html.spec.whatwg.org/multipage#dom-attachinternals>
fn AttachInternals(&self) -> Fallible<DomRoot<ElementInternals>> {
fn AttachInternals(&self, can_gc: CanGc) -> Fallible<DomRoot<ElementInternals>> {
let element = self.as_element();
// Step 1: If this's is value is not null, then throw a "NotSupportedError" DOMException
if element.get_is().is_some() {
@ -620,7 +620,7 @@ impl HTMLElementMethods<crate::DomTypeHolder> for HTMLElement {
}
// Step 5: If this's attached internals is non-null, then throw an "NotSupportedError" DOMException
let internals = element.ensure_element_internals();
let internals = element.ensure_element_internals(can_gc);
if internals.attached() {
return Err(Error::NotSupported);
}
@ -1227,7 +1227,7 @@ impl FormControl for HTMLElement {
fn set_form_owner(&self, form: Option<&HTMLFormElement>) {
debug_assert!(self.is_form_associated_custom_element());
self.as_element()
.ensure_element_internals()
.ensure_element_internals(CanGc::note())
.set_form_owner(form);
}