Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-07-22 23:03:42 +01:00
Code Issues Projects Releases Packages Wiki Activity

add CanGc as argument to methods in Element (#36464)

Browse source 
add CanGc as argument to methods in Element

Testing: These changes do not require tests because they are a refactor.
Addresses part of https://github.com/servo/servo/issues/34573.

Signed-off-by: Yerkebulan Tulibergenov <yerkebulan@gmail.com>
This commit is contained in:
Yerkebulan Tulibergenov 2025-04-10 23:21:50 -07:00 • committed by GitHub
parent 3c5da6588d
commit c8ecb57d97
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
9 changed files with 61 additions and 52 deletions
Download patch file Download diff file Expand all files Collapse all files

6
components/script/dom/htmlformelement.rs
View file

@ -1129,6 +1129,7 @@ impl HTMLFormElement {
&self,
submitter: Option<FormSubmitterElement>,
encoding: Option<&'static Encoding>,
can_gc: CanGc,
) -> Vec<FormDatum> {
let controls = self.controls.borrow();
let mut data_set = Vec::new();
@ -1177,7 +1178,8 @@ impl HTMLFormElement {
let custom = child.downcast::<HTMLElement>().unwrap();
if custom.is_form_associated_custom_element() {
// https://html.spec.whatwg.org/multipage/#face-entry-construction
let internals = custom.upcast::<Element>().ensure_element_internals();
let internals =
custom.upcast::<Element>().ensure_element_internals(can_gc);
internals.perform_entry_construction(&mut data_set);
// Otherwise no form value has been set so there is nothing to do.
}
@ -1225,7 +1227,7 @@ impl HTMLFormElement {
self.constructing_entry_list.set(true);
// Step 3-6
let ret = self.get_unclean_dataset(submitter, encoding);
let ret = self.get_unclean_dataset(submitter, encoding, can_gc);
let window = self.owner_window();