From c8f542afacce91a71e7805f7b610d5ec66195b8d Mon Sep 17 00:00:00 2001 From: Simon Sapin Date: Thu, 4 Jan 2018 17:47:38 +0100 Subject: [PATCH] We use Nigthly Cargo with Stable Rust MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Nightly now has incremental compilation as a stable feature, but that’s not in the stable channel yet. --- python/servo/command_base.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/python/servo/command_base.py b/python/servo/command_base.py index 1f3d784ebc3..bfc7192df97 100644 --- a/python/servo/command_base.py +++ b/python/servo/command_base.py @@ -297,9 +297,8 @@ class CommandBase(object): def set_use_geckolib_toolchain(self, use_geckolib_toolchain=True): self._use_geckolib_toolchain = use_geckolib_toolchain if use_geckolib_toolchain: - # Cargo maintainer's position is that CARGO_INCREMENTAL is a nightly-only feature - # and should not be used on the stable channel. - # https://github.com/rust-lang/cargo/issues/3835 + # We use Cargo Nightly 1.24 with Rust 1.22, + # it passes `-C incremental` to rustc, which is new in Rust 1.24. self.config["build"]["incremental"] = False def toolchain(self):