Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-07-23 07:13:52 +01:00
Code Issues Projects Releases Packages Wiki Activity

script: Call content_and_heritage_changed from children_changed instead of add_child / remove_child.

Browse source 
add_child / remove_child aren't called when a node character data changed. This
is important for finer grained invalidation.

The only test that tests this is now wallpapered, but won't be after #19164.
This commit is contained in:
Emilio Cobos Álvarez 2017-11-10 13:04:58 +01:00
parent a3f2fae561
commit c9d9304912
No known key found for this signature in database
GPG key ID: 056B727BB9C1027C
1 changed files with 1 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

6
components/script/dom/node.rs
View file

@ -266,8 +266,6 @@ impl Node {
debug_assert!(!node.get_flag(NodeFlags::HAS_DIRTY_DESCENDANTS)); debug_assert!(!node.get_flag(NodeFlags::HAS_DIRTY_DESCENDANTS));
vtable_for(&&*node).bind_to_tree(parent_in_doc); vtable_for(&&*node).bind_to_tree(parent_in_doc);
} }
let document = new_child.owner_doc();
document.content_and_heritage_changed(new_child, NodeDamage::OtherNodeDamage);
} }
/// Removes the given child from this node's list of children. /// Removes the given child from this node's list of children.
@ -318,9 +316,6 @@ impl Node {
ScriptThread::enqueue_callback_reaction(&*element, CallbackReaction::Disconnected, None); ScriptThread::enqueue_callback_reaction(&*element, CallbackReaction::Disconnected, None);
} }
} }
self.owner_doc().content_and_heritage_changed(self, NodeDamage::OtherNodeDamage);
child.owner_doc().content_and_heritage_changed(child, NodeDamage::OtherNodeDamage);
} }
pub fn to_untrusted_node_address(&self) -> UntrustedNodeAddress { pub fn to_untrusted_node_address(&self) -> UntrustedNodeAddress {
@ -2504,6 +2499,7 @@ impl VirtualMethods for Node {
if let Some(list) = self.child_list.get() { if let Some(list) = self.child_list.get() {
list.as_children_list().children_changed(mutation); list.as_children_list().children_changed(mutation);
} }
self.owner_doc().content_and_heritage_changed(self, NodeDamage::OtherNodeDamage);
} }
// This handles the ranges mentioned in steps 2-3 when removing a node. // This handles the ranges mentioned in steps 2-3 when removing a node.