mirror of
https://github.com/servo/servo.git
synced 2025-08-05 13:40:08 +01:00
Auto merge of #25903 - mmatyas:webgl_fns_framebuf_render_validation_fix, r=jdm
Improved the WebGL2 framebuffer render validation It seems `MissingColorAttachment` should be returned only when all of the color attachments are missing. <!-- Please describe your changes on the following line: --> cc @jdm @zakorgy --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
This commit is contained in:
commit
ca25e18791
3 changed files with 1 additions and 23 deletions
|
@ -468,7 +468,7 @@ impl WebGLFramebuffer {
|
|||
return CompleteForRendering::Complete;
|
||||
}
|
||||
|
||||
if self.colors.iter().any(|att| att.borrow().is_none()) {
|
||||
if self.colors.iter().all(|att| att.borrow().is_none()) {
|
||||
return CompleteForRendering::MissingColorAttachment;
|
||||
}
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue