Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-13 09:25:32 +01:00
Code Issues Projects Releases Packages Wiki Activity

Set all tracing spans to trace level for now (#34256)

Browse source 
* Clean up tracing instrumentation

Signed-off-by: Delan Azabani <dazabani@igalia.com>

* Set all tracing spans to trace level for now

Signed-off-by: Delan Azabani <dazabani@igalia.com>

---------

Signed-off-by: Delan Azabani <dazabani@igalia.com>
This commit is contained in:
Delan Azabani 2024-11-19 10:53:43 +08:00 • committed by GitHub
parent 9a98852806
commit caf2467649
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
11 changed files with 158 additions and 164 deletions
Download patch file Download diff file Expand all files Collapse all files

2
components/fonts/font_context.rs
View file

@ -280,7 +280,7 @@ impl FontContext {
/// cache thread and a `FontDescriptor` which contains the styling parameters.
#[cfg_attr(
feature = "tracing",
tracing::instrument(skip_all, fields(servo_profiling = true))
tracing::instrument(skip_all, fields(servo_profiling = true), level = "trace")
)]
fn create_font(
&self,

21
components/fonts/system_font_service.rs
View file

@ -147,20 +147,15 @@ impl SystemFontService {
#[cfg_attr(
feature = "tracing",
tracing::instrument(skip_all, fields(servo_profiling = true))
tracing::instrument(skip_all, fields(servo_profiling = true), level = "trace")
)]
fn run(&mut self) {
loop {
let msg = self.port.recv().unwrap();
#[cfg(feature = "tracing")]
let span = tracing::span!(
tracing::Level::TRACE,
"SystemFontServiceMessage",
servo_profiling = true
);
#[cfg(feature = "tracing")]
let _enter = span.enter();
let _span =
tracing::trace_span!("SystemFontServiceMessage", servo_profiling = true).entered();
match msg {
SystemFontServiceMessage::GetFontTemplates(
font_descriptor,
@ -192,7 +187,7 @@ impl SystemFontService {
#[cfg_attr(
feature = "tracing",
tracing::instrument(skip_all, fields(servo_profiling = true))
tracing::instrument(skip_all, fields(servo_profiling = true), level = "trace")
)]
fn fetch_new_keys(&mut self) {
if !self.free_font_keys.is_empty() && !self.free_font_instance_keys.is_empty() {
@ -212,7 +207,7 @@ impl SystemFontService {
#[cfg_attr(
feature = "tracing",
tracing::instrument(skip_all, fields(servo_profiling = true))
tracing::instrument(skip_all, fields(servo_profiling = true), level = "trace")
)]
fn get_font_templates(
&mut self,
@ -228,7 +223,7 @@ impl SystemFontService {
#[cfg_attr(
feature = "tracing",
tracing::instrument(skip_all, fields(servo_profiling = true))
tracing::instrument(skip_all, fields(servo_profiling = true), level = "trace")
)]
fn refresh_local_families(&mut self) {
self.local_families.clear();
@ -242,7 +237,7 @@ impl SystemFontService {
#[cfg_attr(
feature = "tracing",
tracing::instrument(skip_all, fields(servo_profiling = true))
tracing::instrument(skip_all, fields(servo_profiling = true), level = "trace")
)]
fn find_font_templates(
&mut self,
@ -269,7 +264,7 @@ impl SystemFontService {
#[cfg_attr(
feature = "tracing",
tracing::instrument(skip_all, fields(servo_profiling = true))
tracing::instrument(skip_all, fields(servo_profiling = true), level = "trace")
)]
fn get_font_instance(
&mut self,