Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 14:10:11 +01:00
Code Issues Projects Releases Packages Wiki Activity

Set all tracing spans to trace level for now (#34256)

Browse source 
* Clean up tracing instrumentation

Signed-off-by: Delan Azabani <dazabani@igalia.com>

* Set all tracing spans to trace level for now

Signed-off-by: Delan Azabani <dazabani@igalia.com>

---------

Signed-off-by: Delan Azabani <dazabani@igalia.com>
This commit is contained in:
Delan Azabani 2024-11-19 10:53:43 +08:00 • committed by GitHub
parent 9a98852806
commit caf2467649
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
11 changed files with 158 additions and 164 deletions
Download patch file Download diff file Expand all files Collapse all files

3
components/layout_2020/display_list/clip_path.rs
View file

@ -70,7 +70,8 @@ pub(super) fn build_clip_path_clip_chain_if_necessary(
tracing::instrument(
name = "display_list::build_simple_shape",
skip_all,
fields(servo_profiling = true)
fields(servo_profiling = true),
level = "trace",
)
)]
fn build_simple_shape(

4
components/layout_2020/display_list/mod.rs
View file

@ -182,9 +182,7 @@ impl DisplayList {
root_stacking_context: &StackingContext,
) -> (FnvHashMap<BrowsingContextId, Size2D<f32, CSSPixel>>, bool) {
#[cfg(feature = "tracing")]
let span = tracing::span!(tracing::Level::TRACE, "display_list::build");
#[cfg(feature = "tracing")]
let _enter = span.enter();
let _span = tracing::trace_span!("display_list::build", servo_profiling = true).entered();
let mut builder = DisplayListBuilder {
current_scroll_node_id: self.compositor_info.root_reference_frame_id,
current_reference_frame_scroll_node_id: self.compositor_info.root_reference_frame_id,

3
components/layout_2020/display_list/stacking_context.rs
View file

@ -106,7 +106,8 @@ impl DisplayList {
tracing::instrument(
name = "display_list::build_stacking_context_tree",
skip_all,
fields(servo_profiling = true)
fields(servo_profiling = true),
level = "trace",
)
)]
pub fn build_stacking_context_tree(

9
components/layout_2020/flexbox/layout.rs
View file

@ -395,7 +395,8 @@ impl FlexContainer {
tracing::instrument(
name = "FlexContainer::inline_content_sizes",
skip_all,
fields(servo_profiling = true)
fields(servo_profiling = true),
level = "trace",
)
)]
pub fn inline_content_sizes(
@ -607,7 +608,8 @@ impl FlexContainer {
tracing::instrument(
name = "FlexContainer::layout",
skip_all,
fields(servo_profiling = true)
fields(servo_profiling = true),
level = "trace",
)
)]
pub(crate) fn layout(
@ -2689,7 +2691,8 @@ impl FlexItemBox {
tracing::instrument(
name = "FlexContainer::layout_for_block_content_size",
skip_all,
fields(servo_profiling = true)
fields(servo_profiling = true),
level = "trace",
)
)]
fn layout_for_block_content_size(

10
components/layout_2020/table/layout.rs
View file

@ -1641,7 +1641,12 @@ impl<'a> TableLayout<'a> {
/// only be be called after calling [`TableLayout.compute_measures`].
#[cfg_attr(
feature = "tracing",
tracing::instrument(name = "Table::layout", skip_all, fields(servo_profiling = true))
tracing::instrument(
name = "Table::layout",
skip_all,
fields(servo_profiling = true),
level = "trace",
)
)]
fn layout(
mut self,
@ -2626,7 +2631,8 @@ impl Table {
tracing::instrument(
name = "Table::inline_content_sizes",
skip_all,
fields(servo_profiling = true)
fields(servo_profiling = true),
level = "trace",
)
)]
pub(crate) fn inline_content_sizes(