Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-18 11:55:39 +01:00
Code Issues Projects Releases Packages Wiki Activity

Remove all internal mutability from Request

Browse source
This commit is contained in:
Anthony Ramine 2017-04-01 00:31:00 +02:00
parent f42a63baea
commit cb2eb81208
11 changed files with 362 additions and 376 deletions
Download patch file Download diff file Expand all files Collapse all files

124
tests/unit/net/http_loader.rs
View file

@ -134,7 +134,7 @@ fn test_check_default_headers_loaded_in_every_request() {
*expected_headers.lock().unwrap() = Some(headers.clone());
// Testing for method.GET
let request = Request::from_init(RequestInit {
let mut request = Request::from_init(RequestInit {
url: url.clone(),
method: Method::Get,
destination: Destination::Document,
@ -142,7 +142,7 @@ fn test_check_default_headers_loaded_in_every_request() {
pipeline_id: Some(TEST_PIPELINE_ID),
.. RequestInit::default()
});
let response = fetch(&request, None);
let response = fetch(&mut request, None);
assert!(response.status.unwrap().is_success());
// Testing for method.POST
@ -153,7 +153,7 @@ fn test_check_default_headers_loaded_in_every_request() {
// "Origin: http://example.com/" which do not match for equality so strip trailing '/'
post_headers.set(Origin::from_str(&url_str[..url_str.len()-1]).unwrap());
*expected_headers.lock().unwrap() = Some(post_headers);
let request = Request::from_init(RequestInit {
let mut request = Request::from_init(RequestInit {
url: url.clone(),
method: Method::Post,
destination: Destination::Document,
@ -161,7 +161,7 @@ fn test_check_default_headers_loaded_in_every_request() {
pipeline_id: Some(TEST_PIPELINE_ID),
.. RequestInit::default()
});
let response = fetch(&request, None);
let response = fetch(&mut request, None);
assert!(response.status.unwrap().is_success());
let _ = server.close();
@ -174,7 +174,7 @@ fn test_load_when_request_is_not_get_or_head_and_there_is_no_body_content_length
};
let (mut server, url) = make_server(handler);
let request = Request::from_init(RequestInit {
let mut request = Request::from_init(RequestInit {
url: url.clone(),
method: Method::Post,
body: None,
@ -183,7 +183,7 @@ fn test_load_when_request_is_not_get_or_head_and_there_is_no_body_content_length
pipeline_id: Some(TEST_PIPELINE_ID),
.. RequestInit::default()
});
let response = fetch(&request, None);
let response = fetch(&mut request, None);
assert!(response.status.unwrap().is_success());
let _ = server.close();
@ -199,7 +199,7 @@ fn test_request_and_response_data_with_network_messages() {
let mut request_headers = Headers::new();
request_headers.set(Host { hostname: "bar.foo".to_owned(), port: None });
let request = Request::from_init(RequestInit {
let mut request = Request::from_init(RequestInit {
url: url.clone(),
method: Method::Get,
headers: request_headers,
@ -210,7 +210,7 @@ fn test_request_and_response_data_with_network_messages() {
.. RequestInit::default()
});
let (devtools_chan, devtools_port) = mpsc::channel();
let response = fetch(&request, Some(devtools_chan));
let response = fetch(&mut request, Some(devtools_chan));
assert!(response.status.unwrap().is_success());
let _ = server.close();
@ -288,7 +288,7 @@ fn test_request_and_response_message_from_devtool_without_pipeline_id() {
};
let (mut server, url) = make_server(handler);
let request = Request::from_init(RequestInit {
let mut request = Request::from_init(RequestInit {
url: url.clone(),
method: Method::Get,
destination: Destination::Document,
@ -297,7 +297,7 @@ fn test_request_and_response_message_from_devtool_without_pipeline_id() {
.. RequestInit::default()
});
let (devtools_chan, devtools_port) = mpsc::channel();
let response = fetch(&request, Some(devtools_chan));
let response = fetch(&mut request, Some(devtools_chan));
assert!(response.status.unwrap().is_success());
let _ = server.close();
@ -323,7 +323,7 @@ fn test_redirected_request_to_devtools() {
};
let (mut pre_server, pre_url) = make_server(pre_handler);
let request = Request::from_init(RequestInit {
let mut request = Request::from_init(RequestInit {
url: pre_url.clone(),
method: Method::Post,
destination: Destination::Document,
@ -332,7 +332,7 @@ fn test_redirected_request_to_devtools() {
.. RequestInit::default()
});
let (devtools_chan, devtools_port) = mpsc::channel();
fetch(&request, Some(devtools_chan));
fetch(&mut request, Some(devtools_chan));
let _ = pre_server.close();
let _ = post_server.close();
@ -371,7 +371,7 @@ fn test_load_when_redirecting_from_a_post_should_rewrite_next_request_as_get() {
};
let (mut pre_server, pre_url) = make_server(pre_handler);
let request = Request::from_init(RequestInit {
let mut request = Request::from_init(RequestInit {
url: pre_url.clone(),
method: Method::Post,
destination: Destination::Document,
@ -379,7 +379,7 @@ fn test_load_when_redirecting_from_a_post_should_rewrite_next_request_as_get() {
pipeline_id: Some(TEST_PIPELINE_ID),
.. RequestInit::default()
});
let response = fetch(&request, None);
let response = fetch(&mut request, None);
let _ = pre_server.close();
let _ = post_server.close();
@ -398,7 +398,7 @@ fn test_load_should_decode_the_response_as_deflate_when_response_headers_have_co
};
let (mut server, url) = make_server(handler);
let request = Request::from_init(RequestInit {
let mut request = Request::from_init(RequestInit {
url: url.clone(),
method: Method::Get,
body: None,
@ -407,7 +407,7 @@ fn test_load_should_decode_the_response_as_deflate_when_response_headers_have_co
pipeline_id: Some(TEST_PIPELINE_ID),
.. RequestInit::default()
});
let response = fetch(&request, None);
let response = fetch(&mut request, None);
let _ = server.close();
@ -427,7 +427,7 @@ fn test_load_should_decode_the_response_as_gzip_when_response_headers_have_conte
};
let (mut server, url) = make_server(handler);
let request = Request::from_init(RequestInit {
let mut request = Request::from_init(RequestInit {
url: url.clone(),
method: Method::Get,
body: None,
@ -436,7 +436,7 @@ fn test_load_should_decode_the_response_as_gzip_when_response_headers_have_conte
pipeline_id: Some(TEST_PIPELINE_ID),
.. RequestInit::default()
});
let response = fetch(&request, None);
let response = fetch(&mut request, None);
let _ = server.close();
@ -465,7 +465,7 @@ fn test_load_doesnt_send_request_body_on_any_redirect() {
};
let (mut pre_server, pre_url) = make_server(pre_handler);
let request = Request::from_init(RequestInit {
let mut request = Request::from_init(RequestInit {
url: pre_url.clone(),
body: Some(b"Body on POST!".to_vec()),
method: Method::Post,
@ -474,7 +474,7 @@ fn test_load_doesnt_send_request_body_on_any_redirect() {
pipeline_id: Some(TEST_PIPELINE_ID),
.. RequestInit::default()
});
let response = fetch(&request, None);
let response = fetch(&mut request, None);
let _ = pre_server.close();
let _ = post_server.close();
@ -490,7 +490,7 @@ fn test_load_doesnt_add_host_to_sts_list_when_url_is_http_even_if_sts_headers_ar
};
let (mut server, url) = make_server(handler);
let request = Request::from_init(RequestInit {
let mut request = Request::from_init(RequestInit {
url: url.clone(),
method: Method::Get,
body: None,
@ -500,7 +500,7 @@ fn test_load_doesnt_add_host_to_sts_list_when_url_is_http_even_if_sts_headers_ar
.. RequestInit::default()
});
let context = new_fetch_context(None);
let response = fetch_with_context(&request, &context);
let response = fetch_with_context(&mut request, &context);
let _ = server.close();
@ -520,7 +520,7 @@ fn test_load_sets_cookies_in_the_resource_manager_when_it_get_set_cookie_header_
assert_cookie_for_domain(context.state.cookie_jar.clone(), url.as_str(), None);
let request = Request::from_init(RequestInit {
let mut request = Request::from_init(RequestInit {
url: url.clone(),
method: Method::Get,
body: None,
@ -530,7 +530,7 @@ fn test_load_sets_cookies_in_the_resource_manager_when_it_get_set_cookie_header_
credentials_mode: CredentialsMode::Include,
.. RequestInit::default()
});
let response = fetch_with_context(&request, &context);
let response = fetch_with_context(&mut request, &context);
let _ = server.close();
@ -560,7 +560,7 @@ fn test_load_sets_requests_cookies_header_for_url_by_getting_cookies_from_the_re
cookie_jar.push(cookie, &url, CookieSource::HTTP);
}
let request = Request::from_init(RequestInit {
let mut request = Request::from_init(RequestInit {
url: url.clone(),
method: Method::Get,
body: None,
@ -570,7 +570,7 @@ fn test_load_sets_requests_cookies_header_for_url_by_getting_cookies_from_the_re
credentials_mode: CredentialsMode::Include,
.. RequestInit::default()
});
let response = fetch_with_context(&request, &context);
let response = fetch_with_context(&mut request, &context);
let _ = server.close();
@ -598,7 +598,7 @@ fn test_load_sends_cookie_if_nonhttp() {
cookie_jar.push(cookie, &url, CookieSource::HTTP);
}
let request = Request::from_init(RequestInit {
let mut request = Request::from_init(RequestInit {
url: url.clone(),
method: Method::Get,
body: None,
@ -608,7 +608,7 @@ fn test_load_sends_cookie_if_nonhttp() {
credentials_mode: CredentialsMode::Include,
.. RequestInit::default()
});
let response = fetch_with_context(&request, &context);
let response = fetch_with_context(&mut request, &context);
let _ = server.close();
@ -628,7 +628,7 @@ fn test_cookie_set_with_httponly_should_not_be_available_using_getcookiesforurl(
assert_cookie_for_domain(context.state.cookie_jar.clone(), url.as_str(), None);
let request = Request::from_init(RequestInit {
let mut request = Request::from_init(RequestInit {
url: url.clone(),
method: Method::Get,
body: None,
@ -638,7 +638,7 @@ fn test_cookie_set_with_httponly_should_not_be_available_using_getcookiesforurl(
credentials_mode: CredentialsMode::Include,
.. RequestInit::default()
});
let response = fetch_with_context(&request, &context);
let response = fetch_with_context(&mut request, &context);
let _ = server.close();
@ -662,7 +662,7 @@ fn test_when_cookie_received_marked_secure_is_ignored_for_http() {
assert_cookie_for_domain(context.state.cookie_jar.clone(), url.as_str(), None);
let request = Request::from_init(RequestInit {
let mut request = Request::from_init(RequestInit {
url: url.clone(),
method: Method::Get,
body: None,
@ -672,7 +672,7 @@ fn test_when_cookie_received_marked_secure_is_ignored_for_http() {
credentials_mode: CredentialsMode::Include,
.. RequestInit::default()
});
let response = fetch_with_context(&request, &context);
let response = fetch_with_context(&mut request, &context);
let _ = server.close();
@ -691,7 +691,7 @@ fn test_load_sets_content_length_to_length_of_request_body() {
};
let (mut server, url) = make_server(handler);
let request = Request::from_init(RequestInit {
let mut request = Request::from_init(RequestInit {
url: url.clone(),
method: Method::Post,
body: Some(content.to_vec()),
@ -700,7 +700,7 @@ fn test_load_sets_content_length_to_length_of_request_body() {
pipeline_id: Some(TEST_PIPELINE_ID),
.. RequestInit::default()
});
let response = fetch(&request, None);
let response = fetch(&mut request, None);
let _ = server.close();
@ -719,7 +719,7 @@ fn test_load_uses_explicit_accept_from_headers_in_load_data() {
let mut accept_headers = Headers::new();
accept_headers.set(accept);
let request = Request::from_init(RequestInit {
let mut request = Request::from_init(RequestInit {
url: url.clone(),
method: Method::Get,
headers: accept_headers,
@ -728,7 +728,7 @@ fn test_load_uses_explicit_accept_from_headers_in_load_data() {
pipeline_id: Some(TEST_PIPELINE_ID),
.. RequestInit::default()
});
let response = fetch(&request, None);
let response = fetch(&mut request, None);
let _ = server.close();
@ -748,7 +748,7 @@ fn test_load_sets_default_accept_to_html_xhtml_xml_and_then_anything_else() {
};
let (mut server, url) = make_server(handler);
let request = Request::from_init(RequestInit {
let mut request = Request::from_init(RequestInit {
url: url.clone(),
method: Method::Get,
destination: Destination::Document,
@ -756,7 +756,7 @@ fn test_load_sets_default_accept_to_html_xhtml_xml_and_then_anything_else() {
pipeline_id: Some(TEST_PIPELINE_ID),
.. RequestInit::default()
});
let response = fetch(&request, None);
let response = fetch(&mut request, None);
let _ = server.close();
@ -775,7 +775,7 @@ fn test_load_uses_explicit_accept_encoding_from_load_data_headers() {
let mut accept_encoding_headers = Headers::new();
accept_encoding_headers.set(accept_encoding);
let request = Request::from_init(RequestInit {
let mut request = Request::from_init(RequestInit {
url: url.clone(),
method: Method::Get,
headers: accept_encoding_headers,
@ -784,7 +784,7 @@ fn test_load_uses_explicit_accept_encoding_from_load_data_headers() {
pipeline_id: Some(TEST_PIPELINE_ID),
.. RequestInit::default()
});
let response = fetch(&request, None);
let response = fetch(&mut request, None);
let _ = server.close();
@ -803,7 +803,7 @@ fn test_load_sets_default_accept_encoding_to_gzip_and_deflate() {
};
let (mut server, url) = make_server(handler);
let request = Request::from_init(RequestInit {
let mut request = Request::from_init(RequestInit {
url: url.clone(),
method: Method::Get,
destination: Destination::Document,
@ -811,7 +811,7 @@ fn test_load_sets_default_accept_encoding_to_gzip_and_deflate() {
pipeline_id: Some(TEST_PIPELINE_ID),
.. RequestInit::default()
});
let response = fetch(&request, None);
let response = fetch(&mut request, None);
let _ = server.close();
@ -839,7 +839,7 @@ fn test_load_errors_when_there_a_redirect_loop() {
*url_b_for_a.lock().unwrap() = Some(url_b.clone());
let request = Request::from_init(RequestInit {
let mut request = Request::from_init(RequestInit {
url: url_a.clone(),
method: Method::Get,
destination: Destination::Document,
@ -847,7 +847,7 @@ fn test_load_errors_when_there_a_redirect_loop() {
pipeline_id: Some(TEST_PIPELINE_ID),
.. RequestInit::default()
});
let response = fetch(&request, None);
let response = fetch(&mut request, None);
let _ = server_a.close();
let _ = server_b.close();
@ -882,7 +882,7 @@ fn test_load_succeeds_with_a_redirect_loop() {
*url_b_for_a.lock().unwrap() = Some(url_b.clone());
let request = Request::from_init(RequestInit {
let mut request = Request::from_init(RequestInit {
url: url_a.clone(),
method: Method::Get,
destination: Destination::Document,
@ -890,7 +890,7 @@ fn test_load_succeeds_with_a_redirect_loop() {
pipeline_id: Some(TEST_PIPELINE_ID),
.. RequestInit::default()
});
let response = fetch(&request, None);
let response = fetch(&mut request, None);
let _ = server_a.close();
let _ = server_b.close();
@ -919,7 +919,7 @@ fn test_load_follows_a_redirect() {
};
let (mut pre_server, pre_url) = make_server(pre_handler);
let request = Request::from_init(RequestInit {
let mut request = Request::from_init(RequestInit {
url: pre_url.clone(),
method: Method::Get,
destination: Destination::Document,
@ -927,7 +927,7 @@ fn test_load_follows_a_redirect() {
pipeline_id: Some(TEST_PIPELINE_ID),
.. RequestInit::default()
});
let response = fetch(&request, None);
let response = fetch(&mut request, None);
let _ = pre_server.close();
let _ = post_server.close();
@ -996,7 +996,7 @@ fn test_redirect_from_x_to_y_provides_y_cookies_from_y() {
cookie_jar.push(cookie_y, &url_y, CookieSource::HTTP);
}
let request = Request::from_init(RequestInit {
let mut request = Request::from_init(RequestInit {
url: url_x.clone(),
method: Method::Get,
destination: Destination::Document,
@ -1005,7 +1005,7 @@ fn test_redirect_from_x_to_y_provides_y_cookies_from_y() {
credentials_mode: CredentialsMode::Include,
.. RequestInit::default()
});
let response = fetch_with_context(&request, &context);
let response = fetch_with_context(&mut request, &context);
let _ = server.close();
@ -1040,7 +1040,7 @@ fn test_redirect_from_x_to_x_provides_x_with_cookie_from_first_response() {
let url = url.join("/initial/").unwrap();
let request = Request::from_init(RequestInit {
let mut request = Request::from_init(RequestInit {
url: url.clone(),
method: Method::Get,
destination: Destination::Document,
@ -1049,7 +1049,7 @@ fn test_redirect_from_x_to_x_provides_x_with_cookie_from_first_response() {
credentials_mode: CredentialsMode::Include,
.. RequestInit::default()
});
let response = fetch(&request, None);
let response = fetch(&mut request, None);
let _ = server.close();
@ -1071,7 +1071,7 @@ fn test_if_auth_creds_not_in_url_but_in_cache_it_sets_it() {
};
let (mut server, url) = make_server(handler);
let request = Request::from_init(RequestInit {
let mut request = Request::from_init(RequestInit {
url: url.clone(),
method: Method::Get,
body: None,
@ -1090,7 +1090,7 @@ fn test_if_auth_creds_not_in_url_but_in_cache_it_sets_it() {
context.state.auth_cache.write().unwrap().entries.insert(url.origin().clone().ascii_serialization(), auth_entry);
let response = fetch_with_context(&request, &context);
let response = fetch_with_context(&mut request, &context);
let _ = server.close();
@ -1105,7 +1105,7 @@ fn test_auth_ui_needs_www_auth() {
};
let (mut server, url) = make_server(handler);
let request = Request::from_init(RequestInit {
let mut request = Request::from_init(RequestInit {
url: url.clone(),
method: Method::Get,
body: None,
@ -1116,7 +1116,7 @@ fn test_auth_ui_needs_www_auth() {
.. RequestInit::default()
});
let response = fetch(&request, None);
let response = fetch(&mut request, None);
let _ = server.close();
@ -1139,20 +1139,20 @@ fn test_origin_set() {
let mut origin = Origin::new(url.scheme(), url.host_str().unwrap(), url.port());
*origin_header_clone.lock().unwrap() = Some(origin.clone());
let request = Request::from_init(RequestInit {
let mut request = Request::from_init(RequestInit {
url: url.clone(),
method: Method::Post,
body: None,
origin: url.clone(),
.. RequestInit::default()
});
let response = fetch(&request, None);
let response = fetch(&mut request, None);
assert!(response.status.unwrap().is_success());
let origin_url = ServoUrl::parse("http://example.com").unwrap();
origin = Origin::new(origin_url.scheme(), origin_url.host_str().unwrap(), origin_url.port());
// Test Origin header is set on Get request with CORS mode
let request = Request::from_init(RequestInit {
let mut request = Request::from_init(RequestInit {
url: url.clone(),
method: Method::Get,
mode: RequestMode::CorsMode,
@ -1162,11 +1162,11 @@ fn test_origin_set() {
});
*origin_header_clone.lock().unwrap() = Some(origin.clone());
let response = fetch(&request, None);
let response = fetch(&mut request, None);
assert!(response.status.unwrap().is_success());
// Test Origin header is not set on method Head
let request = Request::from_init(RequestInit {
let mut request = Request::from_init(RequestInit {
url: url.clone(),
method: Method::Head,
body: None,
@ -1175,7 +1175,7 @@ fn test_origin_set() {
});
*origin_header_clone.lock().unwrap() = None;
let response = fetch(&request, None);
let response = fetch(&mut request, None);
assert!(response.status.unwrap().is_success());
let _ = server.close();