Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-04 13:10:20 +01:00
Code Issues Projects Releases Packages Wiki Activity

script: insert the restyle attribute restyle hint when a style attribute is modified.

Browse source
This commit is contained in:
Emilio Cobos Álvarez 2017-01-28 23:45:21 +01:00
parent d37e6f8c66
commit cb304fd42c
No known key found for this signature in database
GPG key ID: 056B727BB9C1027C
1 changed files with 18 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

27
components/script/dom/document.rs
View file

@ -129,7 +129,7 @@ use std::sync::Arc;
use std::time::{Duration, Instant}; use std::time::{Duration, Instant};
use style::attr::AttrValue; use style::attr::AttrValue;
use style::context::{QuirksMode, ReflowGoal}; use style::context::{QuirksMode, ReflowGoal};
use style::restyle_hints::RestyleHint; use style::restyle_hints::{RestyleHint, RESTYLE_STYLE_ATTRIBUTE};
use style::selector_parser::{RestyleDamage, Snapshot}; use style::selector_parser::{RestyleDamage, Snapshot};
use style::str::{split_html_space_chars, str_join}; use style::str::{split_html_space_chars, str_join};
use style::stylesheets::Stylesheet; use style::stylesheets::Stylesheet;
@ -2142,23 +2142,32 @@ impl Document {
RefMut::map(map, |m| m.entry(JS::from_ref(el)).or_insert_with(PendingRestyle::new)) RefMut::map(map, |m| m.entry(JS::from_ref(el)).or_insert_with(PendingRestyle::new))
} }
pub fn ensure_snapshot(&self, el: &Element) -> RefMut<Snapshot> { pub fn element_state_will_change(&self, el: &Element) {
let mut entry = self.ensure_pending_restyle(el); let mut entry = self.ensure_pending_restyle(el);
if entry.snapshot.is_none() { if entry.snapshot.is_none() {
entry.snapshot = Some(Snapshot::new(el.html_element_in_html_document())); entry.snapshot = Some(Snapshot::new(el.html_element_in_html_document()));
} }
RefMut::map(entry, |e| e.snapshot.as_mut().unwrap()) let mut snapshot = entry.snapshot.as_mut().unwrap();
}
pub fn element_state_will_change(&self, el: &Element) {
let mut snapshot = self.ensure_snapshot(el);
if snapshot.state.is_none() { if snapshot.state.is_none() {
snapshot.state = Some(el.state()); snapshot.state = Some(el.state());
} }
} }
pub fn element_attr_will_change(&self, el: &Element, _attr: &Attr) { pub fn element_attr_will_change(&self, el: &Element, attr: &Attr) {
let mut snapshot = self.ensure_snapshot(el); // FIXME(emilio): Kind of a shame we have to duplicate this.
//
// I'm getting rid of the whole hashtable soon anyway, since all it does
// right now is populate the element restyle data in layout, and we
// could in theory do it in the DOM I think.
let mut entry = self.ensure_pending_restyle(el);
if entry.snapshot.is_none() {
entry.snapshot = Some(Snapshot::new(el.html_element_in_html_document()));
}
if attr.local_name() == &local_name!("style") {
entry.hint |= RESTYLE_STYLE_ATTRIBUTE;
}
let mut snapshot = entry.snapshot.as_mut().unwrap();
if snapshot.attrs.is_none() { if snapshot.attrs.is_none() {
let attrs = el.attrs() let attrs = el.attrs()
.iter() .iter()