Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-05 13:40:08 +01:00
Code Issues Projects Releases Packages Wiki Activity

Remove unused FrameChange's document_ready field

Browse source
This commit is contained in:
Roman Zaynetdinov 2016-12-25 11:54:26 +02:00
parent b5909f26cf
commit cb5ceec150
1 changed files with 1 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

11
components/constellation/constellation.rs
View file

@ -412,10 +412,6 @@ struct FrameChange {
/// The pipeline for the document being loaded. /// The pipeline for the document being loaded.
new_pipeline_id: PipelineId, new_pipeline_id: PipelineId,
/// Is this document ready to be activated?
/// TODO: this flag is never set, it can be removed.
document_ready: bool,
/// Is the new document replacing the current document (e.g. a reload) /// Is the new document replacing the current document (e.g. a reload)
/// or pushing it into the session history (e.g. a navigation)? /// or pushing it into the session history (e.g. a navigation)?
replace: bool, replace: bool,
@ -1446,7 +1442,6 @@ impl<Message, LTF, STF> Constellation<Message, LTF, STF>
frame_id: top_level_frame_id, frame_id: top_level_frame_id,
old_pipeline_id: pipeline_id, old_pipeline_id: pipeline_id,
new_pipeline_id: new_pipeline_id, new_pipeline_id: new_pipeline_id,
document_ready: false,
replace: false, replace: false,
}); });
} }
@ -1480,7 +1475,6 @@ impl<Message, LTF, STF> Constellation<Message, LTF, STF>
frame_id: self.root_frame_id, frame_id: self.root_frame_id,
old_pipeline_id: None, old_pipeline_id: None,
new_pipeline_id: root_pipeline_id, new_pipeline_id: root_pipeline_id,
document_ready: false,
replace: false, replace: false,
}); });
self.compositor_proxy.send(ToCompositorMsg::ChangePageUrl(root_pipeline_id, url)); self.compositor_proxy.send(ToCompositorMsg::ChangePageUrl(root_pipeline_id, url));
@ -1585,7 +1579,6 @@ impl<Message, LTF, STF> Constellation<Message, LTF, STF>
frame_id: load_info.info.frame_id, frame_id: load_info.info.frame_id,
old_pipeline_id: load_info.old_pipeline_id, old_pipeline_id: load_info.old_pipeline_id,
new_pipeline_id: load_info.info.new_pipeline_id, new_pipeline_id: load_info.info.new_pipeline_id,
document_ready: false,
replace: load_info.info.replace, replace: load_info.info.replace,
}); });
} }
@ -1630,7 +1623,6 @@ impl<Message, LTF, STF> Constellation<Message, LTF, STF>
frame_id: frame_id, frame_id: frame_id,
old_pipeline_id: None, old_pipeline_id: None,
new_pipeline_id: new_pipeline_id, new_pipeline_id: new_pipeline_id,
document_ready: false,
replace: replace, replace: replace,
}); });
} }
@ -1766,7 +1758,6 @@ impl<Message, LTF, STF> Constellation<Message, LTF, STF>
frame_id: root_frame_id, frame_id: root_frame_id,
old_pipeline_id: Some(source_id), old_pipeline_id: Some(source_id),
new_pipeline_id: new_pipeline_id, new_pipeline_id: new_pipeline_id,
document_ready: false,
replace: replace, replace: replace,
}); });
@ -1937,7 +1928,7 @@ impl<Message, LTF, STF> Constellation<Message, LTF, STF>
.map(|id| (id, true)); .map(|id| (id, true));
let pipeline_id_loaded = self.pending_frames.iter().rev() let pipeline_id_loaded = self.pending_frames.iter().rev()
.find(|x| x.old_pipeline_id == current_pipeline_id) .find(|x| x.old_pipeline_id == current_pipeline_id)
.map(|x| (x.new_pipeline_id, x.document_ready)) .map(|x| (x.new_pipeline_id, false))
.or(current_pipeline_id_loaded); .or(current_pipeline_id_loaded);
if let Err(e) = resp_chan.send(pipeline_id_loaded) { if let Err(e) = resp_chan.send(pipeline_id_loaded) {
warn!("Failed get_pipeline response ({}).", e); warn!("Failed get_pipeline response ({}).", e);