Simplify the implementation of NodeHelpers::child_elements.

This commit is contained in:
Ms2ger 2014-11-02 18:00:02 +01:00
parent 035ff19e4a
commit cb68fbd68e

View file

@ -59,7 +59,7 @@ use libc;
use libc::{uintptr_t, c_void}; use libc::{uintptr_t, c_void};
use std::cell::{Cell, RefCell, Ref, RefMut}; use std::cell::{Cell, RefCell, Ref, RefMut};
use std::default::Default; use std::default::Default;
use std::iter::{Map, Filter, Peekable}; use std::iter::{FilterMap, Peekable};
use std::mem; use std::mem;
use style; use style;
use style::ComputedValues; use style::ComputedValues;
@ -777,13 +777,7 @@ impl<'a> NodeHelpers<'a> for JSRef<'a, Node> {
fn child_elements(self) -> ChildElementIterator<'a> { fn child_elements(self) -> ChildElementIterator<'a> {
self.children() self.children()
.filter(|node| { .filter_map::<JSRef<Element>>(ElementCast::to_ref)
node.is_element()
})
.map(|node| {
let elem: JSRef<Element> = ElementCast::to_ref(node).unwrap();
elem.clone()
})
.peekable() .peekable()
} }
@ -967,10 +961,12 @@ impl RawLayoutNodeHelpers for Node {
// Iteration and traversal // Iteration and traversal
// //
pub type ChildElementIterator<'a> = Peekable<JSRef<'a, Element>, pub type ChildElementIterator<'a> =
Map<'a, JSRef<'a, Node>, Peekable<JSRef<'a, Element>,
JSRef<'a, Element>, FilterMap<'a,
Filter<'a, JSRef<'a, Node>, NodeChildrenIterator<'a>>>>; JSRef<'a, Node>,
JSRef<'a, Element>,
NodeChildrenIterator<'a>>>;
pub struct NodeChildrenIterator<'a> { pub struct NodeChildrenIterator<'a> {
current: Option<JSRef<'a, Node>>, current: Option<JSRef<'a, Node>>,