Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-03 20:50:07 +01:00
Code Issues Projects Releases Packages Wiki Activity

Using Color equality operators to streamline code in

Browse source 
PaintContext and LayoutTask.
This commit is contained in:
Adenilson Cavalcanti 2015-02-03 11:03:09 -08:00
parent 2bfe5cfecd
commit cc404aba1a
2 changed files with 3 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

6
components/gfx/paint_context.rs
View file

@ -730,8 +730,7 @@ impl<'a> PaintContext<'a> {
let mut lighter_color; let mut lighter_color;
let mut darker_color = color::black();; let mut darker_color = color::black();;
// TODO(Savago): Use equality operators when we sync with rust-azure. if color != darker_color {
if color.r != darker_color.r || color.g != darker_color.g || color.b != darker_color.b {
darker_color = self.scale_color(color, if is_groove { 1.0/3.0 } else { 2.0/3.0 }); darker_color = self.scale_color(color, if is_groove { 1.0/3.0 } else { 2.0/3.0 });
lighter_color = color; lighter_color = color;
} else { } else {
@ -775,8 +774,7 @@ impl<'a> PaintContext<'a> {
// You can't scale black color (i.e. 'scaled = 0 * scale', equals black). // You can't scale black color (i.e. 'scaled = 0 * scale', equals black).
let mut scaled_color = color::black(); let mut scaled_color = color::black();
// TODO(Savago): Use equality operators when we sync with rust-azure. if color != scaled_color {
if color.r != scaled_color.r || color.g != scaled_color.g || color.b != scaled_color.b {
scaled_color = match direction { scaled_color = match direction {
Direction::Top | Direction::Left => { Direction::Top | Direction::Left => {
self.scale_color(color, if is_inset { 2.0/3.0 } else { 1.0 }) self.scale_color(color, if is_inset { 2.0/3.0 } else { 1.0 })

5
components/layout/layout_task.rs
View file

@ -678,10 +678,7 @@ impl LayoutTask {
}; };
let black = color::black(); let black = color::black();
// TODO: Use equality operators when we sync with rust-azure. if element_bg_color != black {
if element_bg_color.r != black.r || element_bg_color.g != black.g ||
element_bg_color.b != black.b || element_bg_color.a != black.a {
color = element_bg_color; color = element_bg_color;
break; break;
} }