From 2df7d69b071930ee93444454a70f0fc449d950d1 Mon Sep 17 00:00:00 2001 From: MendyBerger <12537668+MendyBerger@users.noreply.github.com> Date: Mon, 29 May 2023 07:26:07 -0400 Subject: [PATCH 1/3] css `inset` should work on servo-2020 --- components/style/properties/shorthands/position.mako.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/components/style/properties/shorthands/position.mako.rs b/components/style/properties/shorthands/position.mako.rs index 28343b8a562..958056d844d 100644 --- a/components/style/properties/shorthands/position.mako.rs +++ b/components/style/properties/shorthands/position.mako.rs @@ -839,7 +839,7 @@ ${helpers.four_sides_shorthand( "inset", "%s", "specified::LengthPercentageOrAuto::parse", - engines="gecko servo-2013", + engines="gecko servo-2013 servo-2020", spec="https://drafts.csswg.org/css-logical/#propdef-inset", allow_quirks="No", )} From 922e077f1dafd6f8abad1ab700d30897b2acd875 Mon Sep 17 00:00:00 2001 From: MendyBerger <12537668+MendyBerger@users.noreply.github.com> Date: Wed, 31 May 2023 22:07:50 -0400 Subject: [PATCH 2/3] css inset-block/inline should work on servo-2020 --- components/style/properties/shorthands/position.mako.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/components/style/properties/shorthands/position.mako.rs b/components/style/properties/shorthands/position.mako.rs index 958056d844d..facc6fb1a38 100644 --- a/components/style/properties/shorthands/position.mako.rs +++ b/components/style/properties/shorthands/position.mako.rs @@ -849,7 +849,7 @@ ${helpers.two_properties_shorthand( "inset-block-start", "inset-block-end", "specified::LengthPercentageOrAuto::parse", - engines="gecko servo-2013", + engines="gecko servo-2013 servo-2020", spec="https://drafts.csswg.org/css-logical/#propdef-inset-block" )} @@ -858,6 +858,6 @@ ${helpers.two_properties_shorthand( "inset-inline-start", "inset-inline-end", "specified::LengthPercentageOrAuto::parse", - engines="gecko servo-2013", + engines="gecko servo-2013 servo-2020", spec="https://drafts.csswg.org/css-logical/#propdef-inset-inline" )} From 458df8c8848b43d7eb8cb1b525477071beb4dd51 Mon Sep 17 00:00:00 2001 From: Oriol Brufau Date: Mon, 26 Jun 2023 21:58:08 +0200 Subject: [PATCH 3/3] Update test expectations --- .../css/css-logical/animation-002.html.ini | 3 + .../css-logical/logical-box-inset.html.ini | 3 - .../inset-block-inline-shorthand.html.ini | 36 ---------- .../parsing/inset-block-inline-valid.html.ini | 24 ------- .../parsing/inset-shorthand.html.ini | 60 ----------------- .../css-logical/parsing/inset-valid.html.ini | 24 ------- .../css-position/parsing/inset-valid.html.ini | 66 ------------------- 7 files changed, 3 insertions(+), 213 deletions(-) delete mode 100644 tests/wpt/meta/css/css-logical/parsing/inset-block-inline-shorthand.html.ini delete mode 100644 tests/wpt/meta/css/css-logical/parsing/inset-block-inline-valid.html.ini delete mode 100644 tests/wpt/meta/css/css-logical/parsing/inset-shorthand.html.ini delete mode 100644 tests/wpt/meta/css/css-logical/parsing/inset-valid.html.ini delete mode 100644 tests/wpt/meta/css/css-position/parsing/inset-valid.html.ini diff --git a/tests/wpt/meta/css/css-logical/animation-002.html.ini b/tests/wpt/meta/css/css-logical/animation-002.html.ini index 319a3df5890..50e3dcca9d1 100644 --- a/tests/wpt/meta/css/css-logical/animation-002.html.ini +++ b/tests/wpt/meta/css/css-logical/animation-002.html.ini @@ -1,4 +1,7 @@ [animation-002.html] + expected: CRASH + bug: https://github.com/servo/servo/issues/29891 + [Logical properties in animations respect the writing-mode] expected: FAIL diff --git a/tests/wpt/meta/css/css-logical/logical-box-inset.html.ini b/tests/wpt/meta/css/css-logical/logical-box-inset.html.ini index cfcdb98f4b2..f82ae9f5a4a 100644 --- a/tests/wpt/meta/css/css-logical/logical-box-inset.html.ini +++ b/tests/wpt/meta/css/css-logical/logical-box-inset.html.ini @@ -8,9 +8,6 @@ [Test that inset shorthand sets longhands and serializes correctly.] expected: FAIL - [Test that inset-* shorthands set the computed value of both logical and physical longhands, with 'writing-mode: horizontal-tb; direction: ltr; '.] - expected: FAIL - [Test that logical inset-* properties share computed values with their physical associates, with 'writing-mode: horizontal-tb; direction: rtl; '.] expected: FAIL diff --git a/tests/wpt/meta/css/css-logical/parsing/inset-block-inline-shorthand.html.ini b/tests/wpt/meta/css/css-logical/parsing/inset-block-inline-shorthand.html.ini deleted file mode 100644 index 76d1f90cad3..00000000000 --- a/tests/wpt/meta/css/css-logical/parsing/inset-block-inline-shorthand.html.ini +++ /dev/null @@ -1,36 +0,0 @@ -[inset-block-inline-shorthand.html] - [e.style['inset-block'\] = "10px" should set inset-block-end] - expected: FAIL - - [e.style['inset-block'\] = "10px" should set inset-block-start] - expected: FAIL - - [e.style['inset-block'\] = "10px" should not set unrelated longhands] - expected: FAIL - - [e.style['inset-block'\] = "20% auto" should set inset-block-end] - expected: FAIL - - [e.style['inset-block'\] = "20% auto" should set inset-block-start] - expected: FAIL - - [e.style['inset-block'\] = "20% auto" should not set unrelated longhands] - expected: FAIL - - [e.style['inset-inline'\] = "30%" should set inset-inline-end] - expected: FAIL - - [e.style['inset-inline'\] = "30%" should set inset-inline-start] - expected: FAIL - - [e.style['inset-inline'\] = "30%" should not set unrelated longhands] - expected: FAIL - - [e.style['inset-inline'\] = "auto 40px" should set inset-inline-end] - expected: FAIL - - [e.style['inset-inline'\] = "auto 40px" should set inset-inline-start] - expected: FAIL - - [e.style['inset-inline'\] = "auto 40px" should not set unrelated longhands] - expected: FAIL diff --git a/tests/wpt/meta/css/css-logical/parsing/inset-block-inline-valid.html.ini b/tests/wpt/meta/css/css-logical/parsing/inset-block-inline-valid.html.ini deleted file mode 100644 index 7b99d530925..00000000000 --- a/tests/wpt/meta/css/css-logical/parsing/inset-block-inline-valid.html.ini +++ /dev/null @@ -1,24 +0,0 @@ -[inset-block-inline-valid.html] - [e.style['inset-block'\] = "auto" should set the property value] - expected: FAIL - - [e.style['inset-block'\] = "-10px" should set the property value] - expected: FAIL - - [e.style['inset-block'\] = "calc(10px - 0.5em) -20%" should set the property value] - expected: FAIL - - [e.style['inset-block'\] = "auto auto" should set the property value] - expected: FAIL - - [e.style['inset-inline'\] = "-20%" should set the property value] - expected: FAIL - - [e.style['inset-inline'\] = "calc(10px - 0.5em)" should set the property value] - expected: FAIL - - [e.style['inset-inline'\] = "-10px auto" should set the property value] - expected: FAIL - - [e.style['inset-inline'\] = "auto calc(10px + 0.5em)" should set the property value] - expected: FAIL diff --git a/tests/wpt/meta/css/css-logical/parsing/inset-shorthand.html.ini b/tests/wpt/meta/css/css-logical/parsing/inset-shorthand.html.ini deleted file mode 100644 index b15cd925485..00000000000 --- a/tests/wpt/meta/css/css-logical/parsing/inset-shorthand.html.ini +++ /dev/null @@ -1,60 +0,0 @@ -[inset-shorthand.html] - [e.style['inset'\] = "1px 2px 3px 4px" should set bottom] - expected: FAIL - - [e.style['inset'\] = "1px 2px 3px 4px" should set left] - expected: FAIL - - [e.style['inset'\] = "1px 2px 3px 4px" should set right] - expected: FAIL - - [e.style['inset'\] = "1px 2px 3px 4px" should set top] - expected: FAIL - - [e.style['inset'\] = "1px 2px 3px 4px" should not set unrelated longhands] - expected: FAIL - - [e.style['inset'\] = "1px 2px 3px" should set bottom] - expected: FAIL - - [e.style['inset'\] = "1px 2px 3px" should set left] - expected: FAIL - - [e.style['inset'\] = "1px 2px 3px" should set right] - expected: FAIL - - [e.style['inset'\] = "1px 2px 3px" should set top] - expected: FAIL - - [e.style['inset'\] = "1px 2px 3px" should not set unrelated longhands] - expected: FAIL - - [e.style['inset'\] = "1px 2px" should set bottom] - expected: FAIL - - [e.style['inset'\] = "1px 2px" should set left] - expected: FAIL - - [e.style['inset'\] = "1px 2px" should set right] - expected: FAIL - - [e.style['inset'\] = "1px 2px" should set top] - expected: FAIL - - [e.style['inset'\] = "1px 2px" should not set unrelated longhands] - expected: FAIL - - [e.style['inset'\] = "1px" should set bottom] - expected: FAIL - - [e.style['inset'\] = "1px" should set left] - expected: FAIL - - [e.style['inset'\] = "1px" should set right] - expected: FAIL - - [e.style['inset'\] = "1px" should set top] - expected: FAIL - - [e.style['inset'\] = "1px" should not set unrelated longhands] - expected: FAIL diff --git a/tests/wpt/meta/css/css-logical/parsing/inset-valid.html.ini b/tests/wpt/meta/css/css-logical/parsing/inset-valid.html.ini deleted file mode 100644 index 67ee3c69f8b..00000000000 --- a/tests/wpt/meta/css/css-logical/parsing/inset-valid.html.ini +++ /dev/null @@ -1,24 +0,0 @@ -[inset-valid.html] - [e.style['inset'\] = "auto" should set the property value] - expected: FAIL - - [e.style['inset'\] = "-10px" should set the property value] - expected: FAIL - - [e.style['inset'\] = "calc(-0.5em + 10px) -20%" should set the property value] - expected: FAIL - - [e.style['inset'\] = "auto auto" should set the property value] - expected: FAIL - - [e.style['inset'\] = "10px calc(-0.5em + 10px) -30px" should set the property value] - expected: FAIL - - [e.style['inset'\] = "auto auto auto" should set the property value] - expected: FAIL - - [e.style['inset'\] = "10px calc(-0.5em + 10px) auto -30px" should set the property value] - expected: FAIL - - [e.style['inset'\] = "auto auto auto auto" should set the property value] - expected: FAIL diff --git a/tests/wpt/meta/css/css-position/parsing/inset-valid.html.ini b/tests/wpt/meta/css/css-position/parsing/inset-valid.html.ini deleted file mode 100644 index 757be92a9ec..00000000000 --- a/tests/wpt/meta/css/css-position/parsing/inset-valid.html.ini +++ /dev/null @@ -1,66 +0,0 @@ -[inset-valid.html] - [e.style['inset-block'\] = "0" should set the property value] - expected: FAIL - - [e.style['inset-block'\] = "auto" should set the property value] - expected: FAIL - - [e.style['inset-block'\] = "10%" should set the property value] - expected: FAIL - - [e.style['inset-block'\] = "1rem" should set the property value] - expected: FAIL - - [e.style['inset-block'\] = "-10px" should set the property value] - expected: FAIL - - [e.style['inset-block'\] = "-20%" should set the property value] - expected: FAIL - - [e.style['inset-block'\] = "calc(2em + 3ex)" should set the property value] - expected: FAIL - - [e.style['inset-block'\] = "auto auto" should set the property value] - expected: FAIL - - [e.style['inset-block'\] = "100px 100px" should set the property value] - expected: FAIL - - [e.style['inset-block'\] = "10% -5px" should set the property value] - expected: FAIL - - [e.style['inset-block'\] = "1rem calc(0px)" should set the property value] - expected: FAIL - - [e.style['inset-inline'\] = "0" should set the property value] - expected: FAIL - - [e.style['inset-inline'\] = "auto" should set the property value] - expected: FAIL - - [e.style['inset-inline'\] = "10%" should set the property value] - expected: FAIL - - [e.style['inset-inline'\] = "1rem" should set the property value] - expected: FAIL - - [e.style['inset-inline'\] = "-10px" should set the property value] - expected: FAIL - - [e.style['inset-inline'\] = "-20%" should set the property value] - expected: FAIL - - [e.style['inset-inline'\] = "calc(2em + 3ex)" should set the property value] - expected: FAIL - - [e.style['inset-inline'\] = "auto auto" should set the property value] - expected: FAIL - - [e.style['inset-inline'\] = "100px 100px" should set the property value] - expected: FAIL - - [e.style['inset-inline'\] = "10% -5px" should set the property value] - expected: FAIL - - [e.style['inset-inline'\] = "1rem calc(0px)" should set the property value] - expected: FAIL