Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-06-19 22:59:03 +01:00
Code Issues Projects Releases Packages Wiki Activity

auto merge of #1925 : saneyuki/servo/1874, r=jdm

Browse source 
Fix #1874
This commit is contained in:
bors-servo 2014-03-19 14:47:13 -04:00
commit cc77b28761
2 changed files with 21 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/components/script/dom/node.rs
View file

@ -404,10 +404,12 @@ impl NodeHelpers for JS<Node> {
assert!(self.parent_node().is_some()); assert!(self.parent_node().is_some());
let document = document_from_node(self); let document = document_from_node(self);
for node in self.traverse_preorder() { if self.is_in_doc() {
if node.is_element() { for node in self.traverse_preorder() {
let element: JS<Element> = ElementCast::to(&node); if node.is_element() {
element.bind_to_tree_impl(); let element: JS<Element> = ElementCast::to(&node);
element.bind_to_tree_impl();
}
} }
} }

19
src/test/content/test_document_getElementById.html
View file

@ -66,21 +66,32 @@
is(e2, null, "test3-2, the method should return null when the passed id is none in document."); is(e2, null, "test3-2, the method should return null when the passed id is none in document.");
} }
// test 4
{ {
// Ensure that the id attribute only affects elements present in a document // Ensure that the id attribute only affects elements present in a document
let e = document.createElement('div'); let e = document.createElement('div');
e.id = "should-not-exist"; e.id = "should-not-exist";
is(document.getElementById("should-not-exist"), null); is(document.getElementById("should-not-exist"), null, "test 4-0");
document.body.appendChild(e); document.body.appendChild(e);
is(document.getElementById("should-not-exist"), e); is(document.getElementById("should-not-exist"), e, "test 4-1");
} }
// TODO: // TODO:
// test4: "in tree order, within the context object's tree" // test5: "in tree order, within the context object's tree"
// http://dom.spec.whatwg.org/#dom-document-getelementbyid. // http://dom.spec.whatwg.org/#dom-document-getelementbyid.
// TODO: // TODO:
// test5: innerHTML // test6: innerHTML
// test 7
{
// Test that we only cache elements by ID if they're in a document (see #1874).
let s = document.createElement("div");
s.setAttribute("id", "x");
document.createElement("div").appendChild(s);
is(document.getElementById("x"), null, "test 7-0");
}
finish(); finish();
</script> </script>
</body> </body>