Fix document.characterSet not reflecting byte order marks.

The process of decoding the network byte stream to Unicode is backed by
an instance of `encoding_rs::Decoder`, which will switch the encoding it
uses if it finds a BOM in the byte stream. However, this change in
encoding is not communicated back to the caller and so
`document.characterSet` gives the wrong result. This change fixes that.

See whatwg/html#5359 and whatwg/encoding#203 for the spec-level backing
for this change.

Signed-off-by: Andreu Botella <abb@randomunok.com>
This commit is contained in:
Andreu Botella 2020-12-30 09:46:29 +01:00
parent be19c03d96
commit cd34f156f6
8 changed files with 64 additions and 52 deletions

View file

@ -77,7 +77,7 @@ impl DOMParserMethods for DOMParser {
None,
Default::default(),
);
ServoParser::parse_html_document(&document, s, url);
ServoParser::parse_html_document(&document, Some(s), url);
document.set_ready_state(DocumentReadyState::Complete);
Ok(document)
},
@ -97,7 +97,7 @@ impl DOMParserMethods for DOMParser {
None,
Default::default(),
);
ServoParser::parse_xml_document(&document, s, url);
ServoParser::parse_xml_document(&document, Some(s), url);
document.set_ready_state(DocumentReadyState::Complete);
Ok(document)
},