Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-03 04:30:10 +01:00
Code Issues Projects Releases Packages Wiki Activity

Fix document.characterSet not reflecting byte order marks.

Browse source 
The process of decoding the network byte stream to Unicode is backed by
an instance of `encoding_rs::Decoder`, which will switch the encoding it
uses if it finds a BOM in the byte stream. However, this change in
encoding is not communicated back to the caller and so
`document.characterSet` gives the wrong result. This change fixes that.

See whatwg/html#5359 and whatwg/encoding#203 for the spec-level backing
for this change.

Signed-off-by: Andreu Botella <abb@randomunok.com>
This commit is contained in:
Andreu Botella 2020-12-30 09:46:29 +01:00
parent be19c03d96
commit cd34f156f6
8 changed files with 64 additions and 52 deletions
Download patch file Download diff file Expand all files Collapse all files

4
components/script/dom/xmlhttprequest.rs
View file

@ -1488,7 +1488,7 @@ impl XMLHttpRequest {
let (decoded, _, _) = charset.decode(&response);
let document = self.new_doc(IsHTMLDocument::HTMLDocument);
// TODO: Disable scripting while parsing
ServoParser::parse_html_document(&document, DOMString::from(decoded), wr.get_url());
ServoParser::parse_html_document(&document, Some(DOMString::from(decoded)), wr.get_url());
document
}
@ -1499,7 +1499,7 @@ impl XMLHttpRequest {
let (decoded, _, _) = charset.decode(&response);
let document = self.new_doc(IsHTMLDocument::NonHTMLDocument);
// TODO: Disable scripting while parsing
ServoParser::parse_xml_document(&document, DOMString::from(decoded), wr.get_url());
ServoParser::parse_xml_document(&document, Some(DOMString::from(decoded)), wr.get_url());
document
}