Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 06:00:15 +01:00
Code Issues Projects Releases Packages Wiki Activity

Add lint check for &DomRoot<T>

Browse source 
`&DomRoot<T> is strictly less expressive than `&T`, so using it is
pointless.
This commit is contained in:
lberrymage 2019-12-21 12:44:34 -09:00
parent bac9903fbe
commit cd9195056c
9 changed files with 13 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

3
components/script/dom/bindings/serializable.rs
View file

@ -6,7 +6,6 @@
//! (https://html.spec.whatwg.org/multipage/#serializable-objects).
use crate::dom::bindings::reflector::DomObject;
use crate::dom::bindings::root::DomRoot;
use crate::dom::bindings::structuredclone::StructuredDataHolder;
use crate::dom::globalscope::GlobalScope;
@ -25,7 +24,7 @@ pub trait Serializable: DomObject {
fn serialize(&self, sc_holder: &mut StructuredDataHolder) -> Result<StorageKey, ()>;
/// <https://html.spec.whatwg.org/multipage/#deserialization-steps>
fn deserialize(
owner: &DomRoot<GlobalScope>,
owner: &GlobalScope,
sc_holder: &mut StructuredDataHolder,
extra_data: StorageKey,
) -> Result<(), ()>;

4
components/script/dom/bindings/structuredclone.rs
View file

@ -56,7 +56,7 @@ enum StructuredCloneTags {
}
unsafe fn read_blob(
owner: &DomRoot<GlobalScope>,
owner: &GlobalScope,
r: *mut JSStructuredCloneReader,
mut sc_holder: &mut StructuredDataHolder,
) -> *mut JSObject {
@ -88,7 +88,7 @@ unsafe fn read_blob(
}
unsafe fn write_blob(
owner: &DomRoot<GlobalScope>,
owner: &GlobalScope,
blob: DomRoot<Blob>,
w: *mut JSStructuredCloneWriter,
sc_holder: &mut StructuredDataHolder,

3
components/script/dom/bindings/transferable.rs
View file

@ -6,7 +6,6 @@
//! (https://html.spec.whatwg.org/multipage/#transferable-objects).
use crate::dom::bindings::reflector::DomObject;
use crate::dom::bindings::root::DomRoot;
use crate::dom::bindings::structuredclone::StructuredDataHolder;
use crate::dom::globalscope::GlobalScope;
use js::jsapi::MutableHandleObject;
@ -14,7 +13,7 @@ use js::jsapi::MutableHandleObject;
pub trait Transferable: DomObject {
fn transfer(&self, sc_holder: &mut StructuredDataHolder) -> Result<u64, ()>;
fn transfer_receive(
owner: &DomRoot<GlobalScope>,
owner: &GlobalScope,
sc_holder: &mut StructuredDataHolder,
extra_data: u64,
return_object: MutableHandleObject,