Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-06-14 11:24:33 +00:00
Code Issues Projects Releases Packages Wiki Activity

Add lint check for &DomRoot<T>

Browse source 
`&DomRoot<T> is strictly less expressive than `&T`, so using it is
pointless.
This commit is contained in:
lberrymage 2019-12-21 12:44:34 -09:00
parent bac9903fbe
commit cd9195056c
9 changed files with 13 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

2
python/tidy/servo_tidy_tests/rust_tidy.rs
View file

@ -38,7 +38,7 @@ impl test {
}
}
fn test_fun2(y : &String, z : &Vec<f32>, r: &Root<isize>) -> () {
fn test_fun2(y : &String, z : &Vec<f32>, r: &Root<isize>, s: &DomRoot<isize>) -> () {
let x = true;
x
&& x;

1
python/tidy/servo_tidy_tests/test_tidy.py
View file

@ -112,6 +112,7 @@ class CheckTidiness(unittest.TestCase):
self.assertEqual('use &[T] instead of &Vec<T>', next(errors)[2])
self.assertEqual('use &str instead of &String', next(errors)[2])
self.assertEqual('use &T instead of &Root<T>', next(errors)[2])
self.assertEqual('use &T instead of &DomRoot<T>', next(errors)[2])
self.assertEqual('encountered function signature with -> ()', next(errors)[2])
self.assertEqual('operators should go at the end of the first line', next(errors)[2])
self.assertNoMoreErrors(errors)