diff --git a/components/script/dom/webgl_validations/tex_image_2d.rs b/components/script/dom/webgl_validations/tex_image_2d.rs index dc180729902..8a1b9ad9c16 100644 --- a/components/script/dom/webgl_validations/tex_image_2d.rs +++ b/components/script/dom/webgl_validations/tex_image_2d.rs @@ -151,6 +151,13 @@ impl<'a> WebGLValidator for CommonTexImage2DValidator<'a> { } }; + // GL_INVALID_VALUE is generated if target is one of the six cube map 2D + // image targets and the width and height parameters are not equal. + if target.is_cubic() && self.width != self.height { + self.context.webgl_error(InvalidValue); + return Err(TexImageValidationError::InvalidCubicTextureDimensions); + } + // GL_INVALID_VALUE is generated if level is less than 0. if self.level < 0 { self.context.webgl_error(InvalidValue); @@ -287,13 +294,6 @@ impl<'a> WebGLValidator for TexImage2DValidator<'a> { border, } = self.common_validator.validate()?; - // GL_INVALID_VALUE is generated if target is one of the six cube map 2D - // image targets and the width and height parameters are not equal. - if target.is_cubic() && width != height { - context.webgl_error(InvalidValue); - return Err(TexImageValidationError::InvalidCubicTextureDimensions); - } - // GL_INVALID_ENUM is generated if format or data_type is not an // accepted value. let data_type = match TexDataType::from_gl_constant(self.data_type) { diff --git a/components/script/dom/webglprogram.rs b/components/script/dom/webglprogram.rs index 115b866b984..3d4cb5f593c 100644 --- a/components/script/dom/webglprogram.rs +++ b/components/script/dom/webglprogram.rs @@ -303,10 +303,11 @@ impl WebGLProgram { // Check if the name is reserved if name.starts_with("gl_") { - return Err(WebGLError::InvalidOperation); + return Ok(None); } - if name.starts_with("webgl") || name.starts_with("_webgl_") { + // https://www.khronos.org/registry/webgl/specs/latest/1.0/#GLSL_CONSTRUCTS + if name.starts_with("webgl_") || name.starts_with("_webgl_") { return Ok(None); } diff --git a/components/script/dom/webgltexture.rs b/components/script/dom/webgltexture.rs index ef980c75211..45b26997bc3 100644 --- a/components/script/dom/webgltexture.rs +++ b/components/script/dom/webgltexture.rs @@ -109,7 +109,7 @@ impl WebGLTexture { let face_count = match target { constants::TEXTURE_2D => 1, constants::TEXTURE_CUBE_MAP => 6, - _ => return Err(WebGLError::InvalidOperation) + _ => return Err(WebGLError::InvalidEnum) }; self.face_count.set(face_count); self.target.set(Some(target));