Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 22:15:33 +01:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #13729 - cynicaldevil:readAsArrayBuffer, r=Ms2ger

Browse source 
Implemented FileReader::readAsArrayBuffer

<!-- Please describe your changes on the following line: -->
---

<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #12555

<!-- Either: -->
- [X] There are tests for these changes

There's still some small issues, but I suppose most of the work is done:
- test-tidy mentions a `method declared in webidl is missing a comment with a specification link` for the `getResult` method.
- I get an 'unused code' warning for code present in `UnionTypes.rs`, which is auto-generated.

Passing tests:
- [x]  `FileAPI/reading-data-section/filereader_result.html`
- [x]  `FileAPI/reading-data-section/filereader_readAsArrayBuffer.html`
- [x]  `FileAPI/idlharness.html`
- [ ]  `FileAPI/reading-data-section/FileReader-multiple-reads.html`

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---

This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13729)

<!-- Reviewable:end -->
This commit is contained in:
bors-servo 2016-10-31 14:01:18 -05:00 • committed by GitHub
commit ceb18e7d86
7 changed files with 73 additions and 55 deletions
Download patch file Download diff file Expand all files Collapse all files

8
tests/wpt/metadata/FileAPI/fileReader.html.ini
View file

@ -1,8 +0,0 @@
[fileReader.html]
type: testharness
[FileReader States -- abort]
expected: FAIL
[FileReader States -- events]
expected: FAIL

9
tests/wpt/metadata/FileAPI/idlharness.html.ini
View file

@ -21,15 +21,6 @@
[FileReaderSync interface: operation readAsDataURL(Blob)]
expected: FAIL
[FileReader interface: operation readAsArrayBuffer(Blob)]
expected: FAIL
[FileReader interface: new FileReader() must inherit property "readAsArrayBuffer" with the proper type (0)]
expected: FAIL
[FileReader interface: calling readAsArrayBuffer(Blob) on new FileReader() with too few arguments must throw TypeError]
expected: FAIL
[FileReader interface: operation readAsBinaryString(Blob)]
expected: FAIL

9
tests/wpt/metadata/FileAPI/idlharness.worker.js.ini
View file

@ -3,15 +3,6 @@
[URL interface: operation createFor(Blob)]
expected: FAIL
[FileReader interface: operation readAsArrayBuffer(Blob)]
expected: FAIL
[FileReader interface: new FileReader() must inherit property "readAsArrayBuffer" with the proper type (0)]
expected: FAIL
[FileReader interface: calling readAsArrayBuffer(Blob) on new FileReader() with too few arguments must throw TypeError]
expected: FAIL
[FileReaderSync interface: operation readAsArrayBuffer(Blob)]
expected: FAIL

6
tests/wpt/metadata/FileAPI/reading-data-section/FileReader-multiple-reads.html.ini
View file

@ -3,9 +3,3 @@
[test FileReader no InvalidStateError exception in onloadstart event for readAsArrayBuffer]
expected: FAIL
[test FileReader InvalidStateError exception for readAsArrayBuffer]
expected: FAIL
[test FileReader InvalidStateError exception in onloadstart event for readAsArrayBuffer]
expected: FAIL