Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 06:00:15 +01:00
Code Issues Projects Releases Packages Wiki Activity

Stop messing with the case of the attribute name in AttributeHandlers::get_attribute.

Browse source 
This fixes a bug where GetAttributeNS would incorrectly match lower-case
attributes when called with an upper-case argument.
This commit is contained in:
Ms2ger 2014-09-13 11:00:36 +02:00
parent 25f263b751
commit d0e095a3e5
3 changed files with 9 additions and 116 deletions
Download patch file Download diff file Expand all files Collapse all files

12
tests/wpt/metadata/dom/nodes/attributes.html.ini
View file

@ -1,11 +1,5 @@
[attributes.html]
type: testharness
[setAttribute should lowercase its name argument (upper case attribute)]
expected: FAIL
[setAttribute should lowercase its name argument (mixed case attribute)]
expected: FAIL
[setAttribute should set the attribute with the given qualified name]
expected: FAIL
@ -15,12 +9,6 @@
[First set attribute is returned by getAttribute]
expected: FAIL
[Only lowercase attributes are returned on HTML elements (upper case attribute)]
expected: FAIL
[Only lowercase attributes are returned on HTML elements (mixed case attribute)]
expected: FAIL
[First set attribute is returned with mapped attribute set later]
expected: FAIL

96
tests/wpt/metadata/dom/nodes/case.html.ini
View file

@ -6,15 +6,9 @@
[createElementNS http://www.w3.org/1999/xhtml,abc,Abc]
expected: FAIL
[getAttributeNS http://www.w3.org/1999/xhtml,abc,Abc]
expected: FAIL
[createElementNS http://www.w3.org/1999/xhtml,abc,ABC]
expected: FAIL
[getAttributeNS http://www.w3.org/1999/xhtml,abc,ABC]
expected: FAIL
[createElementNS http://www.w3.org/1999/xhtml,abc,\xc3\xa4]
expected: FAIL
@ -27,15 +21,9 @@
[createElementNS http://www.w3.org/1999/xhtml,Abc,Abc]
expected: FAIL
[getAttributeNS http://www.w3.org/1999/xhtml,Abc,Abc]
expected: FAIL
[createElementNS http://www.w3.org/1999/xhtml,Abc,ABC]
expected: FAIL
[getAttributeNS http://www.w3.org/1999/xhtml,Abc,ABC]
expected: FAIL
[createElementNS http://www.w3.org/1999/xhtml,Abc,\xc3\xa4]
expected: FAIL
@ -48,15 +36,9 @@
[createElementNS http://www.w3.org/1999/xhtml,ABC,Abc]
expected: FAIL
[getAttributeNS http://www.w3.org/1999/xhtml,ABC,Abc]
expected: FAIL
[createElementNS http://www.w3.org/1999/xhtml,ABC,ABC]
expected: FAIL
[getAttributeNS http://www.w3.org/1999/xhtml,ABC,ABC]
expected: FAIL
[createElementNS http://www.w3.org/1999/xhtml,ABC,\xc3\xa4]
expected: FAIL
@ -69,15 +51,9 @@
[createElementNS http://www.w3.org/1999/xhtml,\xc3\xa4,Abc]
expected: FAIL
[getAttributeNS http://www.w3.org/1999/xhtml,\xc3\xa4,Abc]
expected: FAIL
[createElementNS http://www.w3.org/1999/xhtml,\xc3\xa4,ABC]
expected: FAIL
[getAttributeNS http://www.w3.org/1999/xhtml,\xc3\xa4,ABC]
expected: FAIL
[createElementNS http://www.w3.org/1999/xhtml,\xc3\xa4,\xc3\xa4]
expected: FAIL
@ -90,84 +66,12 @@
[createElementNS http://www.w3.org/1999/xhtml,\xc3\x84,Abc]
expected: FAIL
[getAttributeNS http://www.w3.org/1999/xhtml,\xc3\x84,Abc]
expected: FAIL
[createElementNS http://www.w3.org/1999/xhtml,\xc3\x84,ABC]
expected: FAIL
[getAttributeNS http://www.w3.org/1999/xhtml,\xc3\x84,ABC]
expected: FAIL
[createElementNS http://www.w3.org/1999/xhtml,\xc3\x84,\xc3\xa4]
expected: FAIL
[createElementNS http://www.w3.org/1999/xhtml,\xc3\x84,\xc3\x84]
expected: FAIL
[getAttributeNS http://www.w3.org/2000/svg,abc,Abc]
expected: FAIL
[getAttributeNS http://www.w3.org/2000/svg,abc,ABC]
expected: FAIL
[getAttributeNS http://www.w3.org/2000/svg,Abc,Abc]
expected: FAIL
[getAttributeNS http://www.w3.org/2000/svg,Abc,ABC]
expected: FAIL
[getAttributeNS http://www.w3.org/2000/svg,ABC,Abc]
expected: FAIL
[getAttributeNS http://www.w3.org/2000/svg,ABC,ABC]
expected: FAIL
[getAttributeNS http://www.w3.org/2000/svg,\xc3\xa4,Abc]
expected: FAIL
[getAttributeNS http://www.w3.org/2000/svg,\xc3\xa4,ABC]
expected: FAIL
[getAttributeNS http://www.w3.org/2000/svg,\xc3\x84,Abc]
expected: FAIL
[getAttributeNS http://www.w3.org/2000/svg,\xc3\x84,ABC]
expected: FAIL
[getAttributeNS http://FOO,abc,Abc]
expected: FAIL
[getAttributeNS http://FOO,abc,ABC]
expected: FAIL
[getAttributeNS http://FOO,Abc,Abc]
expected: FAIL
[getAttributeNS http://FOO,Abc,ABC]
expected: FAIL
[getAttributeNS http://FOO,ABC,Abc]
expected: FAIL
[getAttributeNS http://FOO,ABC,ABC]
expected: FAIL
[getAttributeNS http://FOO,\xc3\xa4,Abc]
expected: FAIL
[getAttributeNS http://FOO,\xc3\xa4,ABC]
expected: FAIL
[getAttributeNS http://FOO,\xc3\x84,Abc]
expected: FAIL
[getAttributeNS http://FOO,\xc3\x84,ABC]
expected: FAIL
[getAttributeNS Abc]
expected: FAIL
[getAttributeNS ABC]
expected: FAIL