Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-05 05:30:08 +01:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #20905 - CYBAI:fix-typo, r=jdm

Browse source 
Fix typo for worklet in globalscope

As the `self` will downcast to `WorkletGlobalScope`, I think it would be more reasonable to name the variable with `worklet` in `if let`.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests because it just renames the variable name

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20905)
<!-- Reviewable:end -->
This commit is contained in:
bors-servo 2018-06-03 09:54:11 -04:00 • committed by GitHub
commit d23bc4f1a4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
components/script/dom/globalscope.rs
View file

@ -300,9 +300,9 @@ impl GlobalScope {
// https://html.spec.whatwg.org/multipage/#script-settings-for-workers:api-base-url // https://html.spec.whatwg.org/multipage/#script-settings-for-workers:api-base-url
return worker.get_url().clone(); return worker.get_url().clone();
} }
if let Some(worker) = self.downcast::<WorkletGlobalScope>() { if let Some(worklet) = self.downcast::<WorkletGlobalScope>() {
// https://drafts.css-houdini.org/worklets/#script-settings-for-worklets // https://drafts.css-houdini.org/worklets/#script-settings-for-worklets
return worker.base_url(); return worklet.base_url();
} }
unreachable!(); unreachable!();
} }
@ -315,9 +315,9 @@ impl GlobalScope {
if let Some(worker) = self.downcast::<WorkerGlobalScope>() { if let Some(worker) = self.downcast::<WorkerGlobalScope>() {
return worker.get_url().clone(); return worker.get_url().clone();
} }
if let Some(worker) = self.downcast::<WorkletGlobalScope>() { if let Some(worklet) = self.downcast::<WorkletGlobalScope>() {
// TODO: is this the right URL to return? // TODO: is this the right URL to return?
return worker.base_url(); return worklet.base_url();
} }
unreachable!(); unreachable!();
} }