Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-10 07:55:33 +01:00
Code Issues Projects Releases Packages Wiki Activity

auto merge of #2592 : june0cho/servo/fix_vertical_align, r=SimonSapin

Browse source 
It fixes the wrong vertical alignment for img element. (related to #2422, #2554)
Worked with @ryanc
This commit is contained in:
bors-servo 2014-06-05 18:58:30 -04:00
commit d293b46944
1 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/components/main/layout/inline.rs
View file

@ -985,7 +985,11 @@ impl InlineFlow {
vertical_align::middle => { vertical_align::middle => {
// TODO: x-height value should be used from font info. // TODO: x-height value should be used from font info.
let xheight = Au(0); let xheight = Au(0);
(-(xheight + fragment.content_height()).scale_by(0.5), false) let fragment_height = fragment.content_height();
let offset_top = -(xheight + fragment_height).scale_by(0.5);
*height_above_baseline = offset_top.scale_by(-1.0);
*depth_below_baseline = fragment_height - *height_above_baseline;
(offset_top, false)
}, },
vertical_align::sub => { vertical_align::sub => {
// TODO: The proper position for subscripts should be used. Lower the baseline to // TODO: The proper position for subscripts should be used. Lower the baseline to