Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-12 08:55:32 +01:00
Code Issues Projects Releases Packages Wiki Activity

script(webdriver): Fix element clear for file (#38536)

Browse source 
When clearing input file with WebDriver, we should set input's filelist
with empty list instead of setting it with None.

Testing:
`./tests/wpt/tests/webdriver/tests/classic/element_send_keys/file_upload.py`

Signed-off-by: PotatoCP <Kenzie.Raditya.Tirtarahardja@huawei.com>
This commit is contained in:
Kenzie Raditya Tirtarahardja 2025-08-09 02:38:35 +08:00 • committed by GitHub
parent 29222c2770
commit d33ae1549d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 5 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
components/script/dom/htmlinputelement.rs
View file

@ -2233,7 +2233,11 @@ impl HTMLInputElement {
self.update_checked_state(self.DefaultChecked(), false);
self.value_changed(can_gc);
// Step 4. Empty selected files
self.filelist.set(None);
if self.filelist.get().is_some() {
let window = self.owner_window();
let filelist = FileList::new(&window, vec![], can_gc);
self.filelist.set(Some(&filelist));
}
// Step 5. invoke the value sanitization algorithm iff
// the type attribute's current state defines one.
// This is covered in `fn sanitize_value` called below.

3
tests/wpt/meta/webdriver/tests/classic/element_send_keys/file_upload.py.ini vendored
View file

@ -2,9 +2,6 @@
[test_multiple_files_send_twice]
expected: FAIL
[test_multiple_files_reset_with_element_clear]
expected: FAIL
[test_single_file_appends_with_multiple_attribute]
expected: FAIL