Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-07-24 15:50:21 +01:00
Code Issues Projects Releases Packages Wiki Activity

Cleanups for future script crate split (#35987)

Browse source 
* script: Avoid direct impl blocks on generated dicts and unions.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* script: Remove references to codegen-specific import module.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Fix tidy.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

---------

Signed-off-by: Josh Matthews <josh@joshmatthews.net>
This commit is contained in:
Josh Matthews 2025-03-16 09:46:14 -04:00 • committed by GitHub
parent 3ecd1c0699
commit d35da38a2f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
43 changed files with 211 additions and 146 deletions
Download patch file Download diff file Expand all files Collapse all files

14
components/script/dom/constantsourcenode.rs
View file

@ -10,6 +10,7 @@ use servo_media::audio::constant_source_node::ConstantSourceNodeOptions as Servo
use servo_media::audio::node::{AudioNodeInit, AudioNodeType};
use servo_media::audio::param::ParamType;
use crate::conversions::Convert;
use crate::dom::audioparam::AudioParam;
use crate::dom::audioscheduledsourcenode::AudioScheduledSourceNode;
use crate::dom::baseaudiocontext::BaseAudioContext;
@ -38,8 +39,9 @@ impl ConstantSourceNode {
can_gc: CanGc,
) -> Fallible<ConstantSourceNode> {
let node_options = Default::default();
let offset = *options.offset;
let source_node = AudioScheduledSourceNode::new_inherited(
AudioNodeInit::ConstantSourceNode(options.into()),
AudioNodeInit::ConstantSourceNode(options.convert()),
context,
node_options, /* 2, MAX, Speakers */
0, /* inputs */
@ -53,7 +55,7 @@ impl ConstantSourceNode {
AudioNodeType::ConstantSourceNode,
ParamType::Offset,
AutomationRate::A_rate,
*options.offset,
offset,
f32::MIN,
f32::MAX,
can_gc,
@ -110,10 +112,10 @@ impl ConstantSourceNodeMethods<crate::DomTypeHolder> for ConstantSourceNode {
}
}
impl<'a> From<&'a ConstantSourceOptions> for ServoMediaConstantSourceOptions {
fn from(options: &'a ConstantSourceOptions) -> Self {
Self {
offset: *options.offset,
impl Convert<ServoMediaConstantSourceOptions> for ConstantSourceOptions {
fn convert(self) -> ServoMediaConstantSourceOptions {
ServoMediaConstantSourceOptions {
offset: *self.offset,
}
}
}