Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-07-22 23:03:42 +01:00
Code Issues Projects Releases Packages Wiki Activity

Cleanups for future script crate split (#35987)

Browse source 
* script: Avoid direct impl blocks on generated dicts and unions.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* script: Remove references to codegen-specific import module.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Fix tidy.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

---------

Signed-off-by: Josh Matthews <josh@joshmatthews.net>
This commit is contained in:
Josh Matthews 2025-03-16 09:46:14 -04:00 • committed by GitHub
parent 3ecd1c0699
commit d35da38a2f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
43 changed files with 211 additions and 146 deletions
Download patch file Download diff file Expand all files Collapse all files

20
components/script/dom/gainnode.rs
View file

@ -10,7 +10,8 @@ use servo_media::audio::gain_node::GainNodeOptions;
use servo_media::audio::node::{AudioNodeInit, AudioNodeType};
use servo_media::audio::param::ParamType;
use crate::dom::audionode::AudioNode;
use crate::conversions::Convert;
use crate::dom::audionode::{AudioNode, AudioNodeOptionsHelper};
use crate::dom::audioparam::AudioParam;
use crate::dom::baseaudiocontext::BaseAudioContext;
use crate::dom::bindings::codegen::Bindings::AudioNodeBinding::{
@ -42,8 +43,9 @@ impl GainNode {
options
.parent
.unwrap_or(2, ChannelCountMode::Max, ChannelInterpretation::Speakers);
let gain = *options.gain;
let node = AudioNode::new_inherited(
AudioNodeInit::GainNode(options.into()),
AudioNodeInit::GainNode(options.convert()),
context,
node_options,
1, // inputs
@ -56,9 +58,9 @@ impl GainNode {
AudioNodeType::GainNode,
ParamType::Gain,
AutomationRate::A_rate,
*options.gain, // default value
f32::MIN, // min value
f32::MAX, // max value
gain, // default value
f32::MIN, // min value
f32::MAX, // max value
can_gc,
);
Ok(GainNode {
@ -112,10 +114,8 @@ impl GainNodeMethods<crate::DomTypeHolder> for GainNode {
}
}
impl<'a> From<&'a GainOptions> for GainNodeOptions {
fn from(options: &'a GainOptions) -> Self {
Self {
gain: *options.gain,
}
impl Convert<GainNodeOptions> for GainOptions {
fn convert(self) -> GainNodeOptions {
GainNodeOptions { gain: *self.gain }
}
}