Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-07-23 07:13:52 +01:00
Code Issues Projects Releases Packages Wiki Activity

Cleanups for future script crate split (#35987)

Browse source 
* script: Avoid direct impl blocks on generated dicts and unions.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* script: Remove references to codegen-specific import module.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Fix tidy.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

---------

Signed-off-by: Josh Matthews <josh@joshmatthews.net>
This commit is contained in:
Josh Matthews 2025-03-16 09:46:14 -04:00 • committed by GitHub
parent 3ecd1c0699
commit d35da38a2f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
43 changed files with 211 additions and 146 deletions
Download patch file Download diff file Expand all files Collapse all files

13
components/script/dom/stereopannernode.rs
View file

@ -8,6 +8,8 @@ use servo_media::audio::node::{AudioNodeInit, AudioNodeType};
use servo_media::audio::param::ParamType;
use servo_media::audio::stereo_panner::StereoPannerOptions as ServoMediaStereoPannerOptions;
use crate::conversions::Convert;
use crate::dom::audionode::AudioNodeOptionsHelper;
use crate::dom::audioparam::AudioParam;
use crate::dom::audioscheduledsourcenode::AudioScheduledSourceNode;
use crate::dom::baseaudiocontext::BaseAudioContext;
@ -48,8 +50,9 @@ impl StereoPannerNode {
if node_options.count > 2 || node_options.count == 0 {
return Err(Error::NotSupported);
}
let pan = *options.pan;
let source_node = AudioScheduledSourceNode::new_inherited(
AudioNodeInit::StereoPannerNode(options.into()),
AudioNodeInit::StereoPannerNode(options.convert()),
context,
node_options,
1, /* inputs */
@ -63,7 +66,7 @@ impl StereoPannerNode {
AudioNodeType::StereoPannerNode,
ParamType::Pan,
AutomationRate::A_rate,
*options.pan,
pan,
-1.,
1.,
CanGc::note(),
@ -120,8 +123,8 @@ impl StereoPannerNodeMethods<crate::DomTypeHolder> for StereoPannerNode {
}
}
impl<'a> From<&'a StereoPannerOptions> for ServoMediaStereoPannerOptions {
fn from(options: &'a StereoPannerOptions) -> Self {
Self { pan: *options.pan }
impl Convert<ServoMediaStereoPannerOptions> for StereoPannerOptions {
fn convert(self) -> ServoMediaStereoPannerOptions {
ServoMediaStereoPannerOptions { pan: *self.pan }
}
}