Create and invoke XML parser for XML documents.

This commit is contained in:
ronak 2015-12-03 17:30:17 -05:00 committed by Josh Matthews
parent 9d3b915cac
commit d38a1a0d03
5 changed files with 95 additions and 40 deletions

View file

@ -268,7 +268,10 @@ impl AsyncResponseListener for ParserContext {
let parser = parser.r(); let parser = parser.r();
let win = parser.window(); let win = parser.window();
self.parser = Some(match parser { self.parser = Some(match parser {
ParserRef::HTML(parser) => TrustedParser::HTML(Trusted::new(win.get_cx(), parser, self.script_chan.clone())), ParserRef::HTML(parser) => TrustedParser::HTML(
Trusted::new(win.get_cx(),
parser,
self.script_chan.clone())),
ParserRef::XML(parser) => TrustedParser::XML(Trusted::new(win.get_cx(), parser, self.script_chan.clone())), ParserRef::XML(parser) => TrustedParser::XML(Trusted::new(win.get_cx(), parser, self.script_chan.clone())),
}); });
@ -288,6 +291,7 @@ impl AsyncResponseListener for ParserContext {
parser.set_plaintext_state(); parser.set_plaintext_state();
}, },
Some(ContentType(Mime(TopLevel::Text, SubLevel::Html, _))) => {}, // Handle text/html Some(ContentType(Mime(TopLevel::Text, SubLevel::Html, _))) => {}, // Handle text/html
Some(ContentType(Mime(TopLevel::Text, SubLevel::Xml, _))) => {}, // Handle text/xml
Some(ContentType(Mime(toplevel, sublevel, _))) => { Some(ContentType(Mime(toplevel, sublevel, _))) => {
if toplevel.as_str() == "application" && sublevel.as_str() == "xhtml+xml" { if toplevel.as_str() == "application" && sublevel.as_str() == "xhtml+xml" {
// Handle xhtml (application/xhtml+xml). // Handle xhtml (application/xhtml+xml).

View file

@ -3,8 +3,10 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
use dom::bindings::cell::DOMRefCell; use dom::bindings::cell::DOMRefCell;
use dom::bindings::codegen::Bindings::ServoXMLParserBinding;
use dom::bindings::global::GlobalRef;
use dom::bindings::js::{JS, Root}; use dom::bindings::js::{JS, Root};
use dom::bindings::reflector::Reflector; use dom::bindings::reflector::{Reflector, reflect_dom_object};
use dom::bindings::trace::JSTraceable; use dom::bindings::trace::JSTraceable;
use dom::document::Document; use dom::document::Document;
use dom::node::Node; use dom::node::Node;
@ -87,7 +89,30 @@ impl<'a> Parser for &'a ServoXMLParser {
} }
impl ServoXMLParser { impl ServoXMLParser {
pub fn new() { #[allow(unrooted_must_root)]
pub fn new(base_url: Option<Url>, document: &Document, pipeline: Option<PipelineId>)
-> Root<ServoXMLParser> {
let sink = Sink {
base_url: base_url,
document: JS::from_ref(document),
};
let tb = XmlTreeBuilder::new(sink);
let tok = tokenizer::XmlTokenizer::new(tb, Default::default());
let parser = ServoXMLParser {
reflector_: Reflector::new(),
tokenizer: DOMRefCell::new(tok),
pending_input: DOMRefCell::new(vec!()),
document: JS::from_ref(document),
suspended: Cell::new(false),
last_chunk_received: Cell::new(false),
pipeline: pipeline,
};
reflect_dom_object(box parser, GlobalRef::Window(document.window()),
ServoXMLParserBinding::Wrap)
} }
pub fn window(&self) -> &Window { pub fn window(&self) -> &Window {
@ -95,19 +120,44 @@ impl ServoXMLParser {
} }
pub fn resume(&self) { pub fn resume(&self) {
panic!() assert!(self.suspended.get());
self.suspended.set(false);
self.parse_sync();
} }
pub fn suspend(&self) { pub fn suspend(&self) {
panic!() assert!(!self.suspended.get());
self.suspended.set(true);
} }
pub fn is_suspended(&self) -> bool { pub fn is_suspended(&self) -> bool {
panic!() self.suspended.get()
} }
pub fn parse_sync(&self) { pub fn parse_sync(&self) {
panic!() // This parser will continue to parse while there is either pending input or
// the parser remains unsuspended.
loop {
self.document.reflow_if_reflow_timer_expired();
let mut pending_input = self.pending_input.borrow_mut();
if !pending_input.is_empty() {
let chunk = pending_input.remove(0);
self.tokenizer.borrow_mut().feed(chunk.into());
}
// Document parsing is blocked on an external resource.
if self.suspended.get() {
return;
}
if pending_input.is_empty() {
break;
}
}
if self.last_chunk_received.get() {
self.finish();
}
} }
pub fn pending_input(&self) -> &DOMRefCell<Vec<String>> { pub fn pending_input(&self) -> &DOMRefCell<Vec<String>> {

View file

@ -6,7 +6,7 @@
use dom::bindings::codegen::Bindings::NodeBinding::NodeMethods; use dom::bindings::codegen::Bindings::NodeBinding::NodeMethods;
use dom::bindings::inheritance::Castable; use dom::bindings::inheritance::Castable;
use dom::bindings::js::{JS, RootedReference}; use dom::bindings::js::{JS, Root, RootedReference};
use dom::comment::Comment; use dom::comment::Comment;
use dom::document::Document; use dom::document::Document;
use dom::documenttype::DocumentType; use dom::documenttype::DocumentType;
@ -14,7 +14,10 @@ use dom::element::{Element, ElementCreator};
use dom::node::Node; use dom::node::Node;
use dom::processinginstruction::ProcessingInstruction; use dom::processinginstruction::ProcessingInstruction;
use dom::servoxmlparser; use dom::servoxmlparser;
use dom::servoxmlparser::ServoXMLParser;
use dom::text::Text;
use msg::constellation_msg::PipelineId; use msg::constellation_msg::PipelineId;
use parse::Parser;
use std::borrow::Cow; use std::borrow::Cow;
use string_cache::QualName; use string_cache::QualName;
use tendril::StrTendril; use tendril::StrTendril;
@ -61,8 +64,14 @@ impl<'a> TreeSink for servoxmlparser::Sink {
} }
fn append(&mut self, parent: JS<Node>, child: NodeOrText<JS<Node>>) { fn append(&mut self, parent: JS<Node>, child: NodeOrText<JS<Node>>) {
let child = self.get_or_create(child); let child = match child {
NodeOrText::AppendNode(n) => Root::from_ref(&*n),
NodeOrText::AppendText(t) => {
let s: String = t.into();
let text = Text::new(DOMString::from(s), &self.document);
Root::upcast(text)
}
};
assert!(parent.AppendChild(child.r()).is_ok()); assert!(parent.AppendChild(child.r()).is_ok());
} }
@ -90,8 +99,14 @@ pub enum ParseContext {
} }
pub fn parse_xml(_document: &Document, pub fn parse_xml(document: &Document,
_input: DOMString, input: DOMString,
_url: Url, url: Url,
_context: ParseContext) { context: ParseContext) {
let parser = match context {
ParseContext::Owner(owner) =>
ServoXMLParser::new(Some(url), document, owner),
};
parser.parse_chunk(String::from(input));
} }

View file

@ -1660,7 +1660,6 @@ impl ScriptTask {
}); });
let content_type = match metadata.content_type { let content_type = match metadata.content_type {
Some(ContentType(Mime(TopLevel::Text, SubLevel::Xml, _))) => { Some(ContentType(Mime(TopLevel::Text, SubLevel::Xml, _))) => {
Some(DOMString::from("text/xml")) Some(DOMString::from("text/xml"))
} }
@ -1675,28 +1674,20 @@ impl ScriptTask {
let loader = DocumentLoader::new_with_task(self.resource_task.clone(), let loader = DocumentLoader::new_with_task(self.resource_task.clone(),
Some(page.pipeline()), Some(page.pipeline()),
Some(incomplete.url.clone())); Some(incomplete.url.clone()));
let document;
match metadata.content_type {
Some(ContentType(Mime(TopLevel::Text, SubLevel::Xml, _))) => { let is_html_document = match metadata.content_type {
document = Document::new(window.r(), Some(ContentType(Mime(TopLevel::Text, SubLevel::Xml, _))) =>
IsHTMLDocument::NonHTMLDocument,
_ => IsHTMLDocument::HTMLDocument,
};
let document = Document::new(window.r(),
Some(final_url.clone()), Some(final_url.clone()),
IsHTMLDocument::NonHTMLDocument, is_html_document,
content_type,
last_modified,
DocumentSource::NotFromParser,
loader);
}
_ => {
document = Document::new(window.r(),
Some(final_url.clone()),
IsHTMLDocument::HTMLDocument,
content_type, content_type,
last_modified, last_modified,
DocumentSource::FromParser, DocumentSource::FromParser,
loader); loader);
}
}
let frame_element = frame_element.r().map(Castable::upcast); let frame_element = frame_element.r().map(Castable::upcast);
window.init_browsing_context(document.r(), frame_element); window.init_browsing_context(document.r(), frame_element);
@ -1738,7 +1729,8 @@ impl ScriptTask {
unsafe { unsafe {
let mut jsval = RootedValue::new(self.get_cx(), UndefinedValue()); let mut jsval = RootedValue::new(self.get_cx(), UndefinedValue());
window.evaluate_js_on_global_with_result(&script_source, jsval.handle_mut()); window.evaluate_js_on_global_with_result(&script_source, jsval.handle_mut());
let strval = DOMString::from_jsval(self.get_cx(), jsval.handle(), let strval = DOMString::from_jsval(self.get_cx(),
jsval.handle(),
StringificationBehavior::Empty); StringificationBehavior::Empty);
strval.unwrap_or(DOMString::new()) strval.unwrap_or(DOMString::new())
} }
@ -1746,8 +1738,7 @@ impl ScriptTask {
DOMString::new() DOMString::new()
}; };
match metadata.content_type { match metadata.content_type {
Some(ContentType(Mime(TopLevel::Text, SubLevel::Xml, _))) => { Some(ContentType(Mime(TopLevel::Text, SubLevel::Xml, _))) => {
parse_xml(document.r(), parse_xml(document.r(),
parse_input, parse_input,
@ -1760,7 +1751,7 @@ impl ScriptTask {
final_url, final_url,
ParseContext::Owner(Some(incomplete.pipeline_id))); ParseContext::Owner(Some(incomplete.pipeline_id)));
} }
} }
page_remover.neuter(); page_remover.neuter();

View file

@ -1,5 +0,0 @@
[contenttype_mimeheader_01.html]
type: testharness
[Custom document.contentType === 'text/xml' when explicitly set to this value]
expected: FAIL